Update good_job in preparation for 4.0 upgrade

[mitchellhenke]

🛠 Summary of changes

We're quite far behind on good_job versions, and a major version update was released back in July. The structure of jobs has changed, and we must complete all jobs scheduled or queued in the old format prior. This is described further in the v3 to v4 update guide.

[zachmargolis]

LGTM! thanks for linking the upgrade guide

In a production console, run GoodJob.v4_ready? which should return true when safely upgradable.

What do you think of augmenting our HeartbeatJob (or something) to add GoodJob.v4_ready? to the log payload so we can get confirmation in the logs we're ready to migrate/deploy before we do?

[mitchellhenke]

LGTM! thanks for linking the upgrade guide

In a production console, run GoodJob.v4_ready? which should return true when safely upgradable.

What do you think of augmenting our HeartbeatJob (or something) to add GoodJob.v4_ready? to the log payload so we can get confirmation in the logs we're ready to migrate/deploy before we do?

Yeah, that's a great idea. I added a new job to run hourly in b4d8d23. I think we could put it in the HeartbeatJob, but I think I'd rather leave that one as simple as possible since we have alerts related to it.