Merged
Conversation
This service provider can be configured for the sample OIDC app for PKCE. changelog: Internal, Local Development, Add PKCE service provider
* Upgrade Faker to latest major version (2.19 -> 3.4.2) * Includes API fixes (i.e., `Faker::Internet.safe_email` is now `Faker::Internet.email`) [skip changelog]
…re request (#11242) Socure requires that we send them the timestamp that the user submitted consent to share their info. A previous commit started recording the timestamp in the `Idv::AgreementController`. This commit does the work to start passing to timestamp to Socure in the applicant hash. [skip changelog] Co-authored-by: Zach Margolis <zachmargolis@users.noreply.github.com>
#11247) * LG-12213: Fix redirect when selecting Face/Touch on unsupported device changelog: Bug Fixes, Two-Factor Authentication, Fix redirect when choosing to authenticate with Face/Touch Unlock on unsupported device if stronger authenticator exists * Remove platform=false expectations from spec * Remove redundant continue_as * Inline email parameter
) We use the `Ddp::Proofer` to communicate with Threatmetrix for device profiling. This returns a `DdpResult` which includes a large hash representing the redacted Threatmetrix response body. This result is eventually logged in the `IdV: doc auth verify proofing results` event. The Threatmetrix response body is large and we are working to move it into its own analytics event. The `account_lex_id` and `session_id` have been identified as especially helpful fields from the response body. Before we move the response body into its own event we are moving these fields onto `DdpResult`. This will cause them to be logged a level above the response body so they are present after we move the response body to its own event. [skip changelog]
changelog: Internal, Protocols, Removes dependency on service provider instance variable
* Move hints assignment into WebAuthn package So that we can actually have test coverage * LG-14327: Remove registration hints for Face or Touch Unlock changelog: Internal, WebAuthn, Remove registration hints for Face or Touch Unlock
changelog: Internal, Code Quality, Remove lingering reference to outdated feature flag
* LG-12377 Remove 404 action for State ID Controller/FSM removal changelog: Internal, In-person proofing, Remove 404 action for State ID Controller/FSM removal
changelog: Internal, Automated Testing, Remove unnecessary quibble loader registration
* do not show remaining attempts warning when the user has not received a failed doc auth result [skip changelog] * Update app/javascript/packages/document-capture/components/document-capture-review-issues.tsx Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com> * add react test for remiaining events * Inline props, remove field value for unknown field example * remove correct file form enforce file --------- Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com> Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
* schedule job once a month * add to config * add specs and fix typo * table data is already getting checked in /reporting test * Add changelog changelog: User-Facing Improvements, Reporting, schedule mfa report [LG-12572] * add test for empty logs * lint fix
amirbey
requested review from
jmdembe,
matthinz,
mitchellhenke and
zachmargolis
matthinz
approved these changes
Sep 19, 2024
jmdembe
approved these changes
Sep 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User-Facing Improvements
Bug Fixes
Internal