Remove dependency on saml_idp instance variable#11246
Merged
Conversation
changelog: Internal, Protocols, Removes dependency on service provider instance variable
mitchellhenke
approved these changes
Sep 17, 2024
app/services/analytics_events.rb
Outdated
| requested_ial:, | ||
| request_signed:, | ||
| matching_cert_serial:, | ||
| matching_cert_serial: nil, |
Contributor
There was a problem hiding this comment.
Is the default needed if it's still being assigned in the method call?
Contributor
Author
There was a problem hiding this comment.
i think some tests were failing until i added this, let me double check. (if they do fail again, i can investigate a little to see if it's a setup issue/a better way to solve it)
Contributor
Author
There was a problem hiding this comment.
seems like it works! maybe i had hit a transient error or something
AShukla-GSA
pushed a commit
that referenced
this pull request
Sep 30, 2024
changelog: Internal, Protocols, Removes dependency on service provider instance variable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changelog: Internal, Protocols, Removes dependency on service provider instance variable
🎫 Ticket
Link to the relevant ticket:
https://gitlab.login.gov/lg-people/Melba/backlog-fy24/-/issues/2 and
LG-4875
🛠 Summary of changes
This is the penultimate step to clear out this old ticket :)
The matching_cert method has been pulled into the request object, rather than the service_provider object. There's one more bit of cleanup to be done on the saml_idp to remove that instance variable, but since all the pieces are in place to remove the IdP's dependency on it, I thought I would do that first.
Updating the IdP code will possibly allow us to remove this ValidationError, which is catching the edge case we've seen in the past where a request that is signed will have an X509 Certificate element in the XML, with no actual certificate embedded in it.