LG-14481: DocAuth infinity attempts remaining bug#11238
Conversation
There was a problem hiding this comment.
do you also want to do a > 0 check on the number of attempts?
There was a problem hiding this comment.
it should be rate limited before remainingSubmitAttempts < 0 which'd be pretty concerning ... if that scenario was to arise, it could be helpful to allow it to happen to surface that deeper problem? 🤔
amirbey
requested review from
a team,
jmax-gsa and
theabrad
and removed request for
a team
amirbey
changed the title
amirbey
force-pushed
the
amirbey/LG-14481-infinity-bug
branch
from
4fa663b to
d8ecc44
Compare
aduth
left a comment
aduth
left a comment
There was a problem hiding this comment.
Can you include test coverage?
app/javascript/packages/document-capture/components/document-capture-review-issues.tsx
Outdated
Show resolved
Hide resolved
that has been tricky ... to recreate this a 500 has to be thrown by the back end which causes issues with Capybara#raise_server_error! which then my attempts to resovle trigger errors in other tests .. i'll reach out for a pair |
I was thinking something in the React component specs, not necessarily a server-side feature spec (although that could be good too, not really sure the circumstances here) |
… a failed doc auth result [skip changelog]
…apture-review-issues.tsx Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com>
amirbey
force-pushed
the
amirbey/LG-14481-infinity-bug
branch
from
670b593 to
b66610f
Compare
* do not show remaining attempts warning when the user has not received a failed doc auth result [skip changelog] * Update app/javascript/packages/document-capture/components/document-capture-review-issues.tsx Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com> * add react test for remiaining events * Inline props, remove field value for unknown field example * remove correct file form enforce file --------- Co-authored-by: Andrew Duthie <1779930+aduth@users.noreply.github.com> Co-authored-by: Andrew Duthie <andrew.duthie@gsa.gov>
4 participants
🎫 Ticket
LG-14481
🛠 Summary of changes
Do not display remaining attempts when the remainingSubmitAttempts property has not been changes and is still Infinity
📜 Testing Plan
For security reasons, you have Infinity attempts remaining to add your ID online.is not rendered.👀 Screenshots
If relevant, include a screenshot or screen capture of the changes.
Before:
After: