LG-12377 Remove 404 action for State ID Controller/FSM removal

[jennyverdeyen]

🎫 Ticket

Link to the relevant ticket:
LG-12377

🛠 Summary of changes

This removes the before action that causes the State ID controller to show a 404 when the in_person_state_id_controller_enabled feature flag is turned off.

📜 Testing Plan

Both URLs work with the controller state enabled:

• Ensure the environment variable in_person_state_id_controller_enabled is set to false in your application.yml and restart the application.
• Go through the IPP flow
• At the state ID page, change the url from /verify/in_person/state_id to /verify/in_person_proofing/state_id
• Observe the state ID page loads and doesn't show a 404 error.

Disabling the controller variable to simulate 50/50 state:

• Ensure the environment variable in_person_state_id_controller_enabled is set to true in your application.yml and restart the application.
• Go through the IPP flow
• At the state ID page go back to application.yml and change the in_person_state_id_controller_enabled to false, and restart the application.
• Refresh the state ID page.
• Observe the state ID page loads and doesn't show a 404 error.

Enabling the controller variable to simulate 50/50 state:

• Ensure the environment variable in_person_state_id_controller_enabled is set to false in your application.yml and restart the application.
• Go through the IPP flow
• At the state ID page go back to application.yml and change the in_person_state_id_controller_enabled to true, and restart the application.
• Refresh the state ID page.
• Observe the state ID page loads and doesn't show a 404 error.

👀 Screenshots

Before:

After:

[gina-yamada]

Nice job Jenny! Good update on those 50/50 specs. We had not implemented those specs on previous steps. Thanks for the before/after screenshots. I included them too from my testing.

[gina-yamada]

@jennyverdeyen Before smashing merge- might be good to confirm flag is disabled in production on AWS