LG-14327: Remove registration hints for Face or Touch Unlock#11251
Merged
LG-14327: Remove registration hints for Face or Touch Unlock#11251
Conversation
So that we can actually have test coverage
changelog: Internal, WebAuthn, Remove registration hints for Face or Touch Unlock
aduth
commented
Sep 17, 2024
Contributor
Author
There was a problem hiding this comment.
A lot of the changes can be summed up as: Minimize what happens in the pack because it's untested, and move the logic into the JavaScript package (tested). Ultimately the only change is that we pass undefined instead of ['client-device', 'hybrid'] for hints when platformAuthenticator is true.
mdiarra3
approved these changes
Sep 17, 2024
AShukla-GSA
pushed a commit
that referenced
this pull request
Sep 30, 2024
* Move hints assignment into WebAuthn package So that we can actually have test coverage * LG-14327: Remove registration hints for Face or Touch Unlock changelog: Internal, WebAuthn, Remove registration hints for Face or Touch Unlock
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-14327
🛠 Summary of changes
Updates WebAuthn registration to avoid passing
hintsfor platform authenticators.This was introduced in LG-12571 (#10382), specifically aimed at improving the experience of registering security keys. While the hints provided for platform authenticators weren't intended or expected to have an impact, it was discovered that providing these hints can cause browsers to impose additional constraints for registration (see related Slack discussion). Specifically, Chrome on macOS prevents the user from registering their device if iCloud Keychain syncing is not available.
📜 Testing Plan
Before: You'd be unable.
After: You can save a device-bound credential.
👀 Screenshots