LG-12213: Fix redirect when selecting Face/Touch on unsupported device#11247
Merged
LG-12213: Fix redirect when selecting Face/Touch on unsupported device#11247
Conversation
changelog: Bug Fixes, Two-Factor Authentication, Fix redirect when choosing to authenticate with Face/Touch Unlock on unsupported device if stronger authenticator exists
mitchellhenke
approved these changes
Sep 17, 2024
AShukla-GSA
pushed a commit
that referenced
this pull request
Sep 30, 2024
#11247) * LG-12213: Fix redirect when selecting Face/Touch on unsupported device changelog: Bug Fixes, Two-Factor Authentication, Fix redirect when choosing to authenticate with Face/Touch Unlock on unsupported device if stronger authenticator exists * Remove platform=false expectations from spec * Remove redundant continue_as * Inline email parameter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎫 Ticket
LG-12213
🛠 Summary of changes
Fixes an issue where a user may be redirected away from authenticating with Face or Touch Unlock if they are on an unsupported device, and if they have a stronger authenticator available.
For context, we detect if the current device has a platform authenticator available when signing in, and if they're on a "supported" device for enrolling Face or Touch Unlock (iOS 16+, Android 9+). If they are not on a supported device, but the user has a platform authenticator credential associated with their device, we redirect them to their list of MFA options. They can choose to still authenticator with Face or Touch Unlock if they want.
The problem is that the check was performed when the user arrives at the Face or Touch Unlock verification screen, assuming they'd be redirected their above other methods since it's a strong authentication method. However, there is a stronger authentication method (PIV), and so the user wouldn't necessarily always be directed to verify with Face or Touch Unlock. If the user has both a PIV and Face or Touch Unlock, and chose to switch to use their Face or Touch Unlock, they'd be confusingly bounced out of the Face or Touch Unlock verification screen.
📜 Testing Plan
Before: It would appear that nothing happened, that the page listing MFA methods reloaded. It would work on a second submission.
After: You arrive at the Face or Touch Unlock verification screen.
👀 Screenshots
Before:
before.mov
After:
after.mov