Upgrade Faker to latest major version#11206
Merged
Conversation
zachmargolis
approved these changes
Sep 5, 2024
[skip changelog]
lmgeorge
force-pushed
the
lmgeorge/upgrade-faker
branch
from
166d564 to
94aae65
Compare
lmgeorge
added
status - ready for review
ruby
jc-gsa
approved these changes
Sep 16, 2024
AShukla-GSA
pushed a commit
that referenced
this pull request
Sep 30, 2024
* Upgrade Faker to latest major version (2.19 -> 3.4.2) * Includes API fixes (i.e., `Faker::Internet.safe_email` is now `Faker::Internet.email`) [skip changelog]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade Faker to latest major version (2.19 -> 3.4.2)
Faker::Internet.safe_emailis nowFaker::Internet.email)