Remove unnecessary quibble loader registration#11256
Merged
Conversation
changelog: Internal, Automated Testing, Remove unnecessary quibble loader registration
mitchellhenke
approved these changes
Sep 18, 2024
AShukla-GSA
pushed a commit
that referenced
this pull request
Sep 30, 2024
changelog: Internal, Automated Testing, Remove unnecessary quibble loader registration
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🛠 Summary of changes
Updates how we use
quibblefor JavaScript module substitution in tests to avoid explicitly passingloaderoption to Mocha.This resolves a warning that's logged when running tests, and will likely help avoid a future incompatibility when Node.js removes the
--loaderflag:It's no longer necessary to pass the loader option in newer versions of Node.js, because Quibble ✨ automagically ✨ registers the hooks behind the scenes.
https://github.com/testdouble/quibble#es-modules-support
📜 Testing Plan
Verify build passes.
Verify
yarn testpasses, and doesn't log the warning shown above.