Release 2022-09-01 - (expected chart version 4.23.0)#2664
Merged
Conversation
* Move mls-test-cli from deps image to builder image * Add changelog entry
Co-authored-by: Stefan Berthold <stefan.berthold@wire.com>
`dist-newstyle`: The directory name depends on the cabal version. `cabal clean` does the job (using the tool itself to manage it's cache). `~/.cabal`: We shouldn't delete the whole folder as it may contain a manually tweaked `config` file. Deleting `~/.cabal/store` should be sufficient. If `$CABAL_DIR` is set, it's taken into account. Co-authored-by: Stefan Matting <smatting@users.noreply.github.com>
* Remove dangling references in haddocks. (I tried, but couldn't find what they are supposed to refer to any more.) * Move related record fields next to each other. * Typo. * Changelog. * hi ci * hi ci Co-authored-by: Leif Battermann <leif.battermann@wire.com>
Co-authored-by: Stefan Matting <stefan@wire.com>
* Add mls secrets to galley chart and settings * Store MLS private keys in a map * Document mlsPrivateKeyPaths setting * Add functions to load private keys in x509 format * Use x509 private keys * Do not use a map to store key pairs * Expose MLS public keys in an endpoint * Add CHANGELOG entries * Add testing private key to CI config * Add mls secret to galley integration * Add purpose to MLS private keys * Cannot use paths as secret keys in helm charts * Add purpose to mlsPrivateKeyPaths in galley chart * Fix yaml formatting of test private key * Add purpose to docs Co-authored-by: Stefan Matting <stefan@wire.com>
* migrated `LoginId` to schema-profunctor
* Rename `delete-cache-on-linker-errors` makefile rule to `full-clean`. * rm trailing whitespace.
) Old documentation was at https://github.com/zinfra/backend-wiki/wiki/Checklists and was partially outdated due to hegemony not being a thing anymore. Updated docs.
This avoids some templating errors when deploying the chart without any secrets as the templating code can assume that `.Values.secrets` is a map and not `null`.
added information on finding and deleting users that are not part of …
a hegemony leftover maybe still useful in the future. (see also zinfra/cailleach#1317)
* charts/coturn: refine error message * charts/coturn: add TLS support. This commit adds options to expose the coturn control plane over TLS. Additionally, when operating with TLS enabled, it adds a sidecar process to the coturn pods so that coturn is signalled to reload certificates when they change on disk. * charts/coturn: update README * changelog: update.
Co-authored-by: yupri <69316518+yu-pri@users.noreply.github.com> Co-authored-by: Arthur Wolf <wolf.arthur@gmail.com> Co-authored-by: Stefan Matting <stefan@wire.com>
* Do not throw for unsupported proposal types * Application code for serialising an AppAck * Add a test for unsupported proposals * Add a roundtrip test for serialiseMLSVector - Works via the ExtensionVector test type * Provide serialiseMLSBytesLazy Co-authored-by: Paolo Capriotti <paolo@capriotti.io>
* feat: implement UserPendingActivationStore effect * wip: try to implement paginatation in polysemy * more wip * Revert "more wip" This reverts commit bb1296a. * Revert "wip: try to implement paginatation in polysemy" This reverts commit 3004be8. * fix: reimplement page streaming * changelog.d * move Galley.Effects.Paging into polysemy-wire-zoo * make format * changelog.d * use paging effect * make format * fix integration tests
Removed the test "user tries to remove themselves from conversation". In the test, the group creator was creating a remove commit which was then send by Bob to the backend. It is not working anymore, since now it is made sure by the backend that Bob creates all his commits himself. Switching to Bob creating the remove commit for his clients won't work either, since OpenMLS would forbid to create a commit in which the user even removes one of his/her own clients. Thus, the test was beyond repairable. However, there might be the option to craft a remove commit for Bob without OpenMLS later on when crafting MLS messages is available. Co-authored-by: Paolo Capriotti <paolo@capriotti.io>
* Skip check when adding clients of existing user * MLS-capable clients should have key packages * Test getMLSClients * Also return *all* clients in getMLSClients * Fix getMLSClients integration test * Add CHANGELOG entries * Address review comments * Refactor getMLSClients Return a set of `ClientInfo` instead of two sets * Fix integration test for getMLSClients
(for compilation speed)
* Update DB API. * Update implementation. * Fix query rendering. * schema migration * add client id to the endpoint path, fix test * added uid to nonce, as client id is only unique together with the uid * change nonce ttl to word32 Co-authored-by: Leif Battermann <leif.battermann@wire.com>
wire-server-deploy delivered a different version as used here for integration tests.
Co-authored-by: Stefan Matting <stefan@wire.com> Co-authored-by: Stefan Matting <smatting@users.noreply.github.com> Co-authored-by: Florian Klink <flokli@flokli.de>
zebot
added
the
ok-to-test
jschaul
reviewed
Sep 1, 2022
Contributor
* Update CHANGELOG.md: missing PR number hash. * tweak changelog according to PR review
jschaul
force-pushed
the
release_2022-09-01_09_47
branch
from
33edb4a to
7245a46
Compare
Member
fisx
approved these changes
Sep 1, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
12 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[2022-09-01] (Chart Release 4.23.0)
Release notes
GET i/mls/clientshas been changed, and it now returns a list ofClientInfoinstead of a list ofClientId. (Improve MLS client checks #2631)API changes
Fix key package error description (Fix key package error description #2651)
Expose MLS public keys in a new endpoint
GET /mls/public-keys. (Add option for MLS private keys #2602)Features
The coturn chart now supports exposing the control port over TLS. (Add TLS support to coturn Helm chart #2620)
Forward all MLS default proposal types ([FS-721] Forward All Default Proposals #2628)
New endpoints
HEADandGET /nonce/clientsto request new nonces for client certificate requests (coming up soon). (Sqservices 1721 acme be new nonce endpoint #2641)Bug fixes and other updates
Fix cql-io bug where restarting whole cassandra cluster could cause downtime. Upstream changes in https://gitlab.com/twittner/cql-io/-/merge_requests/20 (Fix cql-io bug where restarting C* cluster could cause downtime #2640)
Improve client check when adding clients to MLS conversations (Improve MLS client checks #2631)
Documentation
Move developer docs onto docs.wire.com (instead of exposing them on github only) (Publish developer docs #2622, 2649)
Make target audience explicit on docs.wire.com (Make target audience explicit on docs.wire.com. #2662)
Internal changes
Support for external Add proposals (Add support for MLS External Add Proposals #2567)
Add additional checks on incoming MLS messages:
Apply changes introduced by cabal-fmt. (apply cabal-fmt #2624)
Remove some redudant constraints in brig (Brig: Remove redundant constraints #2638)
Brig Polysemy: Port UserPendingActivationStore to polysemy (Brig Polysemy: Port UserPendingActivationStore to polysemy #2636)
Add build instructions for developers (Add build instructions for developers #2621)
Add make target
delete-cache-on-linker-errorsto delete all Haskell compilation related caches. This is useful in cases where the development environment gets into an inconsistent state. (Sanitizedelete-cache-on-linker-errorsmake target #2623)Replace cassandra table
client_noncewithnonceand introduce key (Make nonces lookuppable by client ids #2655)Move Paging effect from galley into polysemy-wire-zoo (Move paging effect into polysemy-wire-zoo #2648)
Fix broken hls-hlint-plugin in nix env (Fix broken hls-hlint-plugin in nix env #2629)
Adjust developer PR template and document config and API procedures in-tree. (port checklist documentation over to docs, and adjust PR template #2617)
Add mls-test-cli to builder image (Add mls-test-cli to builder image #2626)
Add mls-test-cli to deps image (Add mls-test-cli to deps image #2630)
mls-test-cli: Use Cargo.lock file when building (mls-test-cli - use Cargo.lock #2634)
Move common Arbitrary instances to types-common package for compilation speed (Move common Arbitrary instances to types-common package. #2658)
LoginIdmigrated to schema-profunctor (SQSERVICES-1645-backend-servantify-brig-auth-api #2633, Sqservices 1645 backend servantify brig auth api 2 #2645)Improve cleaning rules in Makefile. (We only need one rule for
make clean. #2639)Fix typos, dangling reference in source code haddocs, etc. (Typos etc. #2586)
Update the Elastic Search version used for running integration tests to the one that is delivered by wire-server-deploy. (Run integration tests with delivered Elastic Search version #2656)
Federation changes