Skip to content

Sqservices 1721 acme be new nonce endpoint#2641

Merged
battermann merged 33 commits intodevelopfrom
SQSERVICES-1721-acme-be-new-nonce-endpoint
Aug 24, 2022
Merged

Sqservices 1721 acme be new nonce endpoint#2641
battermann merged 33 commits intodevelopfrom
SQSERVICES-1721-acme-be-new-nonce-endpoint

Conversation

@battermann
Copy link
Contributor

@battermann battermann commented Aug 22, 2022

https://wearezeta.atlassian.net/browse/SQSERVICES-1721

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • If HTTP endpoint paths have been added or renamed, or feature configs have changed, the endpoint / config-flag checklist (see Wire-employee only backend wiki page) has been followed.
  • If configuration options have been added or removed, check docs/developer/adding-config-options and follow the steps there.
  • If a cassandra schema migration has been added, I ran make git-add-cassandra-schema to update the cassandra schema documentation.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.
    • If new config options introduced: added usage description under docs/reference/config-options.md
    • If public end-points have been changed or added: does nginz need un upgrade?

@battermann battermann temporarily deployed to cachix August 22, 2022 10:51 Inactive
@battermann battermann temporarily deployed to cachix August 22, 2022 10:51 Inactive
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Aug 22, 2022
@battermann battermann temporarily deployed to cachix August 22, 2022 12:41 Inactive
@battermann battermann temporarily deployed to cachix August 22, 2022 12:41 Inactive
@battermann battermann temporarily deployed to cachix August 22, 2022 13:55 Inactive
@battermann battermann temporarily deployed to cachix August 22, 2022 13:55 Inactive
@battermann battermann temporarily deployed to cachix August 22, 2022 15:31 Inactive
@battermann battermann temporarily deployed to cachix August 22, 2022 15:31 Inactive
@battermann battermann temporarily deployed to cachix August 22, 2022 15:34 Inactive
@battermann battermann temporarily deployed to cachix August 22, 2022 15:34 Inactive
@battermann battermann temporarily deployed to cachix August 22, 2022 15:38 Inactive
@battermann battermann temporarily deployed to cachix August 22, 2022 15:38 Inactive
@battermann battermann temporarily deployed to cachix August 23, 2022 07:19 Inactive
@battermann battermann temporarily deployed to cachix August 23, 2022 07:19 Inactive
@battermann battermann temporarily deployed to cachix August 23, 2022 11:54 Inactive
Co-authored-by: fisx <mf@zerobuzz.net>
@battermann battermann temporarily deployed to cachix August 23, 2022 12:04 Inactive
@battermann battermann temporarily deployed to cachix August 23, 2022 12:04 Inactive
@battermann battermann temporarily deployed to cachix August 23, 2022 13:11 Inactive
@battermann battermann temporarily deployed to cachix August 23, 2022 13:11 Inactive
Co-authored-by: fisx <mf@zerobuzz.net>
@battermann battermann temporarily deployed to cachix August 23, 2022 13:11 Inactive
@battermann battermann temporarily deployed to cachix August 23, 2022 13:11 Inactive
Copy link
Contributor

@fisx fisx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Except for the CI problem (haven't looked what it's about) and the remaining unresolved comments (which we discussed offline), this is ready.

@battermann battermann temporarily deployed to cachix August 23, 2022 14:38 Inactive
@battermann battermann temporarily deployed to cachix August 23, 2022 14:38 Inactive
@battermann battermann temporarily deployed to cachix August 23, 2022 14:46 Inactive
@battermann battermann temporarily deployed to cachix August 23, 2022 14:46 Inactive
@battermann battermann temporarily deployed to cachix August 23, 2022 14:56 Inactive
@battermann battermann temporarily deployed to cachix August 23, 2022 14:56 Inactive
@battermann battermann merged commit 3b2084c into develop Aug 24, 2022
@battermann battermann deleted the SQSERVICES-1721-acme-be-new-nonce-endpoint branch August 24, 2022 06:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants