Skip to content

Typos etc.#2586

Merged
fisx merged 6 commits intodevelopfrom
SQSERVICES-1687-fix-search-flags
Aug 22, 2022
Merged

Typos etc.#2586
fisx merged 6 commits intodevelopfrom
SQSERVICES-1687-fix-search-flags

Conversation

@fisx
Copy link
Contributor

@fisx fisx commented Jul 29, 2022

A few trivialities that happened in the context of exploring https://wearezeta.atlassian.net/browse/SQSERVICES-1687 Hopefully uncontroversial?

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • If this PR changes development workflow or dependencies, they have been A) automated and B) documented under docs/developer/. All efforts have been taken to minimize development setup breakage or slowdown for co-workers.
  • If HTTP endpoint paths have been added or renamed, or feature configs have changed, the endpoint / config-flag checklist (see Wire-employee only backend wiki page) has been followed.
  • If a cassandra schema migration has been added, I ran make git-add-cassandra-schema to update the cassandra schema documentation.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.
    • If new config options introduced: added usage description under docs/reference/config-options.md
    • If new config options introduced: recommended measures to be taken by on-premise instance operators.
    • If a cassandra schema migration is backwards incompatible (see also these docs), measures to be taken by on-premise instance operators are explained.
    • If a data migration (not schema migration) introduced: measures to be taken by on-premise instance operators.
    • If public end-points have been changed or added: does nginz need un upgrade?
    • If internal end-points have been added or changed: which services have to be deployed in a specific order?

@fisx fisx temporarily deployed to cachix July 29, 2022 09:46 Inactive
fisx added 3 commits August 16, 2022 14:57
(I tried, but couldn't find what they are supposed to refer to any
more.)
@fisx fisx force-pushed the SQSERVICES-1687-fix-search-flags branch from 7ba80c6 to 50d3c76 Compare August 16, 2022 12:57
@fisx fisx temporarily deployed to cachix August 16, 2022 12:57 Inactive
@fisx fisx temporarily deployed to cachix August 16, 2022 12:57 Inactive
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Aug 16, 2022
@fisx fisx changed the title Fix search feature config API Typos etc. Aug 16, 2022
@fisx fisx temporarily deployed to cachix August 16, 2022 13:00 Inactive
@fisx fisx temporarily deployed to cachix August 16, 2022 13:00 Inactive
@fisx fisx marked this pull request as ready for review August 16, 2022 13:01
@fisx fisx requested a review from battermann August 16, 2022 13:01
@fisx fisx temporarily deployed to cachix August 16, 2022 20:04 Inactive
@fisx fisx temporarily deployed to cachix August 16, 2022 20:04 Inactive
Copy link
Contributor

@elland elland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now if we can get CI to agree!

@battermann battermann temporarily deployed to cachix August 22, 2022 07:28 Inactive
@battermann battermann temporarily deployed to cachix August 22, 2022 07:28 Inactive
@battermann
Copy link
Contributor

ran feature api integration locally, all green, so I kicked CI again

@fisx fisx merged commit 7b4b128 into develop Aug 22, 2022
@fisx fisx deleted the SQSERVICES-1687-fix-search-flags branch August 22, 2022 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants