Add additional checks on incoming MLS messages#2618
Merged
stefanwire merged 26 commits intodevelopfrom Aug 26, 2022
Merged
Conversation
9ed67f9 to
6363065
Compare
5a39cff to
95fab2d
Compare
95fab2d to
21469e1
Compare
elland
reviewed
Aug 22, 2022
2340ace to
3cc68bc
Compare
pcapriotti
approved these changes
Aug 26, 2022
Contributor
pcapriotti
left a comment
There was a problem hiding this comment.
Looks good. Minor comments below.
Co-authored-by: Paolo Capriotti <paolo@capriotti.io>
eb979e1 to
69c7365
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/FS-797
Removed the test
"user tries to remove themselves from conversation". In the test, the group creator was creating a remove commit which was then send by Bob to the backend. It is not working anymore, since now it is made sure by the backend that Bob creates all his commits himself. Switching to Bob creating the remove commit for his clients won't work either, since OpenMLS would forbid to create a commit in which the user even removes one of his/her own clients. Thus, the test was beyond repairable. However, there might be the option to craft a remove commit for Bob without OpenMLS later on when crafting MLS messages is available.Checklist
changelog.d.