Skip to content

Add additional checks on incoming MLS messages#2618

Merged
stefanwire merged 26 commits intodevelopfrom
sb/FS-797/sendermatchesuser
Aug 26, 2022
Merged

Add additional checks on incoming MLS messages#2618
stefanwire merged 26 commits intodevelopfrom
sb/FS-797/sendermatchesuser

Conversation

@stefanwire
Copy link
Contributor

@stefanwire stefanwire commented Aug 16, 2022

https://wearezeta.atlassian.net/browse/FS-797

Removed the test "user tries to remove themselves from conversation". In the test, the group creator was creating a remove commit which was then send by Bob to the backend. It is not working anymore, since now it is made sure by the backend that Bob creates all his commits himself. Switching to Bob creating the remove commit for his clients won't work either, since OpenMLS would forbid to create a commit in which the user even removes one of his/her own clients. Thus, the test was beyond repairable. However, there might be the option to craft a remove commit for Bob without OpenMLS later on when crafting MLS messages is available.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

@stefanwire stefanwire temporarily deployed to cachix August 16, 2022 11:56 Inactive
@stefanwire stefanwire temporarily deployed to cachix August 16, 2022 11:56 Inactive
@zebot zebot added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Aug 16, 2022
@stefanwire stefanwire force-pushed the sb/FS-797/sendermatchesuser branch from 9ed67f9 to 6363065 Compare August 17, 2022 16:46
@stefanwire stefanwire temporarily deployed to cachix August 17, 2022 16:46 Inactive
@stefanwire stefanwire temporarily deployed to cachix August 17, 2022 16:46 Inactive
@pcapriotti pcapriotti temporarily deployed to cachix August 18, 2022 13:10 Inactive
@pcapriotti pcapriotti temporarily deployed to cachix August 18, 2022 13:10 Inactive
@stefanwire stefanwire force-pushed the sb/FS-797/sendermatchesuser branch from 5a39cff to 95fab2d Compare August 19, 2022 14:23
@stefanwire stefanwire temporarily deployed to cachix August 19, 2022 14:23 Inactive
@stefanwire stefanwire temporarily deployed to cachix August 19, 2022 14:23 Inactive
@stefanwire stefanwire force-pushed the sb/FS-797/sendermatchesuser branch from 95fab2d to 21469e1 Compare August 22, 2022 07:48
@stefanwire stefanwire temporarily deployed to cachix August 22, 2022 07:48 Inactive
@stefanwire stefanwire temporarily deployed to cachix August 22, 2022 07:48 Inactive
@stefanwire stefanwire temporarily deployed to cachix August 22, 2022 08:22 Inactive
@stefanwire stefanwire temporarily deployed to cachix August 22, 2022 08:22 Inactive
@stefanwire stefanwire temporarily deployed to cachix August 22, 2022 09:01 Inactive
@stefanwire stefanwire temporarily deployed to cachix August 22, 2022 09:01 Inactive
@stefanwire stefanwire temporarily deployed to cachix August 22, 2022 10:16 Inactive
@stefanwire stefanwire temporarily deployed to cachix August 22, 2022 10:16 Inactive
@stefanwire stefanwire temporarily deployed to cachix August 22, 2022 11:31 Inactive
@stefanwire stefanwire temporarily deployed to cachix August 22, 2022 11:31 Inactive
@stefanwire stefanwire temporarily deployed to cachix August 22, 2022 14:16 Inactive
@stefanwire stefanwire temporarily deployed to cachix August 22, 2022 14:16 Inactive
@stefanwire stefanwire temporarily deployed to cachix August 23, 2022 09:18 Inactive
@stefanwire stefanwire temporarily deployed to cachix August 23, 2022 09:18 Inactive
@stefanwire stefanwire temporarily deployed to cachix August 24, 2022 09:04 Inactive
@stefanwire stefanwire temporarily deployed to cachix August 24, 2022 09:04 Inactive
@stefanwire stefanwire temporarily deployed to cachix August 24, 2022 09:33 Inactive
@stefanwire stefanwire force-pushed the sb/FS-797/sendermatchesuser branch from 2340ace to 3cc68bc Compare August 24, 2022 12:22
@stefanwire stefanwire temporarily deployed to cachix August 24, 2022 12:22 Inactive
@stefanwire stefanwire temporarily deployed to cachix August 24, 2022 12:23 Inactive
@stefanwire stefanwire temporarily deployed to cachix August 24, 2022 14:50 Inactive
@stefanwire stefanwire temporarily deployed to cachix August 24, 2022 14:50 Inactive
@stefanwire stefanwire temporarily deployed to cachix August 24, 2022 15:19 Inactive
@stefanwire stefanwire temporarily deployed to cachix August 24, 2022 15:19 Inactive
@stefanwire stefanwire temporarily deployed to cachix August 25, 2022 08:07 Inactive
@stefanwire stefanwire temporarily deployed to cachix August 25, 2022 08:07 Inactive
@stefanwire stefanwire marked this pull request as ready for review August 25, 2022 08:08
Copy link
Contributor

@pcapriotti pcapriotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Minor comments below.

@stefanwire stefanwire temporarily deployed to cachix August 26, 2022 07:40 Inactive
@stefanwire stefanwire temporarily deployed to cachix August 26, 2022 07:40 Inactive
@stefanwire stefanwire force-pushed the sb/FS-797/sendermatchesuser branch from eb979e1 to 69c7365 Compare August 26, 2022 08:16
@stefanwire stefanwire temporarily deployed to cachix August 26, 2022 08:16 Inactive
@stefanwire stefanwire temporarily deployed to cachix August 26, 2022 08:16 Inactive
@stefanwire stefanwire merged commit e7f2f3a into develop Aug 26, 2022
@stefanwire stefanwire deleted the sb/FS-797/sendermatchesuser branch August 26, 2022 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants