SQSERVICES-1645-backend-servantify-brig-auth-api#2633
Merged
battermann merged 4 commits intodevelopfrom Aug 22, 2022
Merged
Conversation
battermann
changed the title
zebot
added
the
ok-to-test
battermann
force-pushed
the
SQSERVICES-1645-backend-servantify-brig-auth-api
branch
from
a3ba28d to
5ca44c4
Compare
battermann
force-pushed
the
SQSERVICES-1645-backend-servantify-brig-auth-api
branch
from
5ca44c4 to
0d2fe98
Compare
fisx
approved these changes
Aug 19, 2022
| loginIdFailFast = testCase "LoginId parser: invalid email, valid phone" $ do | ||
| let actual :: Maybe LoginId = Aeson.decode "{\"email\":\"invalid-email\",\"phone\":\"+123456789\"}" | ||
| let expected = Nothing | ||
| assertEqual "should fail if any provided login id is invalid" expected actual |
Contributor
There was a problem hiding this comment.
nice tests! now you could also do the same for a broken phone number and correct email, to make sure we're actually running all parsers before picking a valid value. (not crazy important, but it's easy and nice.)
battermann
deleted the
SQSERVICES-1645-backend-servantify-brig-auth-api
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
changelog.d.