Conversation
Contributor
fisx
commented
Aug 22, 2022
fisx
commented
- simplify and consolidate make rule names
- drop hint in case of compiler error
Contributor
Author
|
feel free to merge it this is green from ci and reviewer! |
elland
approved these changes
Aug 22, 2022
supersven
requested changes
Aug 22, 2022
zebot
added
the
ok-to-test
supersven
approved these changes
Aug 22, 2022
Contributor
supersven
left a comment
supersven
left a comment
There was a problem hiding this comment.
Now, it looks good to me 👍
Thanks for taking the effort to clean this up.
akshaymankar
requested changes
Aug 22, 2022
Member
akshaymankar
left a comment
akshaymankar
left a comment
There was a problem hiding this comment.
This is not a good idea, this will delete all the cache in CI and CI will take more than an hour to compile things.
Contributor
|
Also, |
- avoids global changes for `make clean`. - keeps `make clean` intact for what the ci expects.
Contributor
Author
|
Thanks @pcapriotti @akshaymankar! Is this better? Or would |
Contributor
|
@fisx |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.