Skip to content

Brig: Remove redundant constraints#2638

Merged
fisx merged 3 commits intowireapp:developfrom
isovector:brig-redundant-constraints
Aug 24, 2022
Merged

Brig: Remove redundant constraints#2638
fisx merged 3 commits intowireapp:developfrom
isovector:brig-redundant-constraints

Conversation

@isovector
Copy link
Contributor

@isovector isovector commented Aug 22, 2022

While doing some polysemy work on brig, I noticed a bunch of redundant constraints. These make it harder to determine which code paths actually require cleaning up before polysemization, so I decided to do a quick cleanup here.

There are also some unrelated changes that make format has been yelling at me about for several PRs now.

Checklist

  • The PR Title explains the impact of the change.
  • The PR description provides context as to why the change should occur and what the code contributes to that effect. This could also be a link to a JIRA ticket or a Github issue, if there is one.
  • changelog.d contains the following bits of information (details):
    • A file with the changelog entry in one or more suitable sub-sections. The sub-sections are marked by directories inside changelog.d.

@isovector
Copy link
Contributor Author

@mdimjasevic PTAL

@elland elland added the ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist label Aug 22, 2022
@isovector
Copy link
Contributor Author

This is ready to merge!

@fisx fisx merged commit ec73e15 into wireapp:develop Aug 24, 2022
@mdimjasevic
Copy link
Contributor

@isovector , my apologies for being slow to react: a combination of being busy with MLS and short absences from work. This one got merged and hopefully I'll be faster to follow up in the future.

On a related note, I have a rather long-standing PR #2450. Hopefully I'll make the PR ready for review some time soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test Approved for running tests in CI, overrides not-ok-to-test if both labels exist

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants