Conversation
07c465e to
4199173
Compare
There was a problem hiding this comment.
Not sure I understand ... spill to disk was not enabled by default in the past either..
There was a problem hiding this comment.
Currently spill to disk adds some overheads to join operator even if spill to disk is disabled just because the code is more complicated to handle the extra functionality. We're moving towards simplification of join operator by removing the spill to disk related code as this functionality is deprecated in favour of Tardigrade.
However, as an intermediate step we're keeping the old complicated join code which supports spill to disk around while creating a new simplified version of the code without spill to disk support. This is a temporary situation until Tardigrade is more mature.
Also, the new simplified join code will receive further optimisations which were not possible in the old code in near future.
The force-spilling-join-operator config is an escape hatch to allow falling back to old code in case of unforeseen issues.
There was a problem hiding this comment.
This should just be:
- Improve performance when spilling to disk is disabled.
The force-spilling-join-operator config is an escape hatch to allow falling back to old code in case of unforeseen issues.
Not just an escape hatch -- it's needed if you do want to run with spilling enabled.
I haven't read that PR, but I don't understand why we need a separate config option vs piggybacking on the options to enable spilling. cc @raunaqmorarka
There was a problem hiding this comment.
We do indeed use existing spill to disk flag to decide whether or not the new code should be used.
The new config is an escape hatch to allow going back to the old code even if spilling is not enabled. This is just to have a fallback in case of unforeseen issues with the new simplified join code.
cc: @sopel39 @skrzypo987
There was a problem hiding this comment.
This should just be:
- Improve performance when spilling to disk is disabled.
The force-spilling-join-operator config is an escape hatch to allow falling back to old code in case of unforeseen issues.
Not just an escape hatch -- it's needed if you do want to run with spilling enabled.
I haven't read that PR, but I don't understand why we need a separate config option vs piggybacking on the options to enable spilling. cc @raunaqmorarka
15b8a65 to
6209b36
Compare
6e6fd21 to
aeaa8e1
Compare
1eb730f to
1f6c64a
Compare
Description
Assemble the release notes for the upcoming Trino 389 release.
Improvement
Docs only.
Add the release notes for Trino 389 with sections for general, security, connectors and other topics as included in the release.
Related issues, pull requests, and links
Fixes #13043
Documentation
( ) No documentation is needed.
(✅) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(✅) No release notes entries required.
( ) Release notes entries required with the following suggested text:
Verification for each commit
Format: commit, committer/maintainer, PR/issue number, ✅ / ❌ rn ✅ / ❌ docs
✅ rn - release note added and verified, or assessed to be not necessary, set to ❌ rn before completion
✅ docs - need for docs assessed and merged, or assessed to be not necessary, set to ❌ docs before completion
30 June 2022 ✅
7c83d02 @losipiuk #13016 ✅ rn ✅ docs
a1bf2b0 @sopel39 #12822 ✅ rn ✅ docs
b04f07a @sopel39 #12822 ✅ rn ✅ docs
2698c6a @sopel39 #12822 ✅ rn ✅ docs
540aacc @findepi #13031 ✅ rn ✅ docs
f77c0d3 @ebyhr #13049 ✅ rn ✅ docs
48c2638 @hashhar #13002 ✅ rn ✅ docs
d908e94 @hashhar #13002 ✅ rn ✅ docs
1f559e3 @martint #12994 ✅ rn ✅ docs
6cb3199 @martint #12994 ✅ rn ✅ docs
1 July 2022 ✅
f427375 @kasiafi #12324 ✅ rn ✅ docs
70315fd @raunaqmorarka #13038 ✅ rn ✅ docs
746eb83 @ebyhr #12952 ✅ rn ✅ docs
4e78e4e @hashhar #13039 ✅ rn ✅ docs
89a9247 @ebyhr #13057 ✅ rn ✅ docs
20979a7 @ebyhr #13058 ✅ rn ✅ docs
2 July 2022 ✅
6792acc @findepi #12951 ✅ rn ✅ docs
67126c5 @findepi #12951 ✅ rn ✅ docs
31de900 @findepi #12951 ✅ rn ✅ docs
3 July 2022 ✅
844f91b @ebyhr #12995 ✅ rn ✅ docs
4 July 2022 ✅
5e9f5ac @ebyhr #12892 ✅ rn ✅ docs
ebd84fc @ebyhr #12896 ✅ rn ✅ docs
3aae05b @ebyhr #12896 ✅ rn ✅ docs
211d2ee @ebyhr #12896 ✅ rn ✅ docs
9401789 @ebyhr #12896 ✅ rn ✅ docs
ff28ed8 @ebyhr #12896 ✅ rn ✅ docs
3defb28 @ebyhr #12896 ✅ rn ✅ docs
f89f14c @ebyhr #12896 ✅ rn ✅ docs
36defc4 @ebyhr #12896 ✅ rn ✅ docs
577d429 @ebyhr #12896 ✅ rn ✅ docs
e4093da @ebyhr #12896 ✅ rn ✅ docs
a57bbd3 @raunaqmorarka #13030 ✅ rn ✅ docs
21c3af3 @raunaqmorarka #13030 ✅ rn ✅ docs
fc7d92a @raunaqmorarka #13030 ✅ rn ✅ docs
87c6ed0 @raunaqmorarka #12762 ✅ rn ✅ docs
5a72170 @kokosing #13077 ✅ rn ✅ docs
5 July 2022 ✅
81638c7 @raunaqmorarka #13084 ✅ rn ✅ docs
be45527 @raunaqmorarka #13084 ✅ rn ✅ docs
07aa6c3 @arhimondr #13065 ✅ rn ✅ docs
9a8ab4a @arhimondr #13064 ✅ rn ✅ docs
bbf4e86 @arhimondr #13064 ✅ rn ✅ docs
6 July 2022 ✅
0fb9647 @ebyhr #13032 ✅ rn ✅ docs
69917da @ebyhr #13098 ✅ rn ✅ docs
bd33388 @ebyhr #13086 ✅ rn ✅ docs
98991ac @raunaqmorarka #12618 ✅ rn ✅ docs
3742422 @raunaqmorarka #12618 ✅ rn ✅ docs
c835a94 @raunaqmorarka #12618 ✅ rn ✅ docs
ba03f22 @raunaqmorarka #12618 ✅ rn ✅ docs
5f70d01 @raunaqmorarka #12618 ✅ rn ✅ docs
c194e87 @raunaqmorarka #12618 ✅ rn ✅ docs
ce60850 @raunaqmorarka #12618 ✅ rn ✅ docs
2fae6e0 @raunaqmorarka #12618 ✅ rn ✅ docs
4c95ee3 @raunaqmorarka #12618 ✅ rn ✅ docs
ca37a38 @martint #13108 ✅ rn ✅ docs
0fec9ea @ebyhr #13101 ✅ rn ✅ docs
7 July 2022 ✅
82bba9a @ebyhr #13096 ✅ rn ✅ docs
d5d8538 @kasiafi #13106 ✅ rn ✅ docs
b81bf76 @martint #13114 ✅ rn ✅ docs
2dc646b @martint #13114 ✅ rn ✅ docs
839ed45 @martint #13089 ✅ rn ✅ docs