Convert Kudu connector test variants to smoke tests#13057
Merged
ebyhr merged 1 commit intotrinodb:masterfrom Jul 1, 2022
chen-ni:issue-12576-part-2
Merged
Convert Kudu connector test variants to smoke tests#13057ebyhr merged 1 commit intotrinodb:masterfrom chen-ni:issue-12576-part-2
ebyhr merged 1 commit intotrinodb:masterfrom
chen-ni:issue-12576-part-2
Conversation
ebyhr
reviewed
Jul 1, 2022
plugin/trino-kudu/src/test/java/io/trino/plugin/kudu/BaseKuduConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-kudu/src/test/java/io/trino/plugin/kudu/TestKuduConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-kudu/src/test/java/io/trino/plugin/kudu/TestKuduConnectorTest.java
Outdated
Show resolved
Hide resolved
Additional non-default configurations should be tested with BaseConnectorSmokeTest to avoid longer CI without loss of test coverage. This is already followed in other connectors.
Member
|
Merged, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
An improvement in testing.
Connector tests.
Improved some tests that shouldn't change any behavior.
Related issues, pull requests, and links
This is the second and last PR to fix #12576.
Following #13002, this PR converts the remaining 2 explicitly-configured Kudu connector tests to smoke tests.
The updated connector test will use the default configuration for building the connector.
Documentation
(x) No documentation is needed.
Release notes
(x) No release notes entries required.