Share nothing when the table snapshots cache is disabled#13086
Merged
ebyhr merged 1 commit intotrinodb:masterfrom Jul 6, 2022
Merged
Conversation
findinpath
commented
Jul 5, 2022
...rino-delta-lake/src/test/java/io/trino/plugin/deltalake/BaseDeltaLakeConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
d365be2 to
7f19b83
Compare
7f19b83 to
e2fe598
Compare
ebyhr
approved these changes
Jul 6, 2022
Member
I think we can add an entry to release note. |
Member
|
Merged, thanks! |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When using the setting for the Delta Lake connector:
the Trino server wouldn't start up correctly anymore and would throw the exception:
Add specific handling to cope with this runtime exception so that, similarly to the other caches from Trino, nothing is shared when the table snapshots cache is disabled.
Fix
Delta Lake connector
Specified behavior NOOP for the situation when the table snapshots cache is disabled.
Related issues, pull requests, and links
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
( ) No release notes entries required.
( ) Release notes entries required with the following suggested text: