Resolve transaction manager race condition#13065
Merged
arhimondr merged 1 commit intotrinodb:masterfrom Jul 5, 2022
Merged
Conversation
losipiuk
reviewed
Jul 3, 2022
Member
There was a problem hiding this comment.
return tryGetTransactionMetadata(transactionId).map(TransactionMetadata::getTransactionInfo); ?
losipiuk
approved these changes
Jul 3, 2022
When query is cancelled while being committed a transaction might disapear in between of the `transactionExists` and `isAutoCommit` methods.
arhimondr
force-pushed
the
transaction-manager-race
branch
from
29e57c7 to
c823cc7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When query is cancelled while being committed a transaction might
disapear in between of the
transactionExistsandisAutoCommitmethods.
Description
Fix
Core engine
Non user visible
Related issues, pull requests, and links
Documentation
(x) No documentation is needed.
( ) Sufficient documentation is included in this PR.
( ) Documentation PR is available with #prnumber.
( ) Documentation issue #issuenumber is filed, and can be handled later.
Release notes
(x) No release notes entries required.
( ) Release notes entries required with the following suggested text: