Skip to content

Extract buildSchemaProperties method in Delta Lake#13096

Merged
ebyhr merged 1 commit intotrinodb:masterfrom
ebyhr:ebi/delta-util
Jul 7, 2022
Merged

Extract buildSchemaProperties method in Delta Lake#13096
ebyhr merged 1 commit intotrinodb:masterfrom
ebyhr:ebi/delta-util

Conversation

@ebyhr
Copy link
Copy Markdown
Member

@ebyhr ebyhr commented Jul 6, 2022

Description

Extract buildSchemaProperties method in Delta Lake
Fixes #12030

Documentation

(x) No documentation is needed.

Release notes

(x) No release notes entries required.

@cla-bot cla-bot bot added the cla-signed label Jul 6, 2022
@ebyhr
Copy link
Copy Markdown
Member Author

ebyhr commented Jul 6, 2022

CI failed

Error:  Tests run: 21, Failures: 1, Errors: 0, Skipped: 20, Time elapsed: 11.824 s <<< FAILURE! - in io.trino.faulttolerant.delta.TestDeltaTaskFailureRecoveryTest
Error:  io.trino.faulttolerant.delta.TestDeltaTaskFailureRecoveryTest.init  Time elapsed: 11.656 s  <<< FAILURE!
com.github.dockerjava.api.exception.InternalServerErrorException: 
Status 500: {"message":"Head \"[https://registry-1.docker.io/v2/testcontainers/ryuk/manifests/0.3.3\](https://registry-1.docker.io/v2/testcontainers/ryuk/manifests/0.3.3/)": Get \"https://auth.docker.io/token?account=githubactions&scope=repository%3Atestcontainers%2Fryuk%3Apull&service=registry.docker.io\": EOF"}
	at org.testcontainers.shaded.com.github.dockerjava.core.DefaultInvocationBuilder.execute(DefaultInvocationBuilder.java:247)
	at org.testcontainers.shaded.com.github.dockerjava.core.DefaultInvocationBuilder.lambda$executeAndStream$1(DefaultInvocationBuilder.java:269)
	at java.base/java.lang.Thread.run(Thread.java:829)

@ebyhr ebyhr requested review from Praveen2112, findinpath and homar July 6, 2022 04:05
Additionally, rename the method and make DeltaLakeSchemaProperties final.
@ebyhr ebyhr force-pushed the ebi/delta-util branch from a477a82 to 6b2b195 Compare July 6, 2022 08:05
@ebyhr ebyhr requested a review from raunaqmorarka July 7, 2022 00:13
@ebyhr ebyhr merged commit 82bba9a into trinodb:master Jul 7, 2022
@ebyhr ebyhr deleted the ebi/delta-util branch July 7, 2022 09:52
@github-actions github-actions bot added this to the 389 milestone Jul 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

DeltaLake extract buildSchemaProperties from CheckpointWriter

3 participants