Retry TestingTrinoServer setup when port is already used#13077
Merged
kokosing merged 1 commit intotrinodb:masterfrom Jul 4, 2022
Merged
Retry TestingTrinoServer setup when port is already used#13077kokosing merged 1 commit intotrinodb:masterfrom
kokosing merged 1 commit intotrinodb:masterfrom
Conversation
Even we typically use random port to setup TestingTrinoServer there is a low likelihood of a race condition where same port is used by two concurrent tests. In such case let's retry.
Member
Author
|
An example of flaky failure looks like the below: |
sopel39
approved these changes
Jul 4, 2022
wendigo
approved these changes
Jul 4, 2022
Member
Where is the random port coming from? we should bind to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retry TestingTrinoServer setup when port is already used
Even we typically use random port to setup TestingTrinoServer there is a
low likelihood of a race condition where same port is used by two
concurrent tests.
In such case let's retry.