This repository was archived by the owner on Dec 16, 2022. It is now read-only.
Conversation
This avoids false alarms from vtctl ValidatePermissionsKeyspace which seems to assume the results will be in a consistent order but doesn't explicitly sort them. MyISAM does not seem to return results in a consistent order from mysql.user or mysql.db without an explicit ORDER BY. Another change: "vtctl GetPermissions" will now print a json result to stdout instead of logging an asciiproto to stderr/INFO so it's easier to examine or debug output. Signed-off-by: David Weitzman <dweitzman@pinterest.com>
Signed-off-by: Adam Saponara <as@php.net>
Signed-off-by: xichengliudui <liuduidui@beyondcent.com>
Signed-off-by: xichengliudui <liuduidui@beyondcent.com>
Signed-off-by: xichengliudui <liuduidui@beyondcent.com>
Signed-off-by: Adam Saponara <as@php.net>
Signed-off-by: Michael Demmer <mdemmer@slack-corp.com>
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
Removes debugging purpose code
Signed-off-by: Adam Saponara <as@php.net>
Signed-off-by: Vitalii <vit.stoyan@gmail.com>
…rlink Fix 404 not found
Fix hyperlink error
…file Add vtexplain Dockerfile
If anyone out there is using legacy behavior, seems like it should be possible to switch to the newer behavior. The legacy behavior has a weaker understanding of what queries do and seems like if anything would be stricter than the newer behavior. Signed-off-by: David Weitzman <dweitzman@pinterest.com>
Signed-off-by: Jon Tirsen <jontirsen@squareup.com>
…blet * Init tablet was using rebuild keyspace locked without holding a lock. This change makes sure it holds a lock before calling rebuild keyspace. Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
Signed-off-by: deepthi <deepthi@planetscale.com>
Fix potential nil pointer error
Signed-off-by: Jon Tirsen <jontirsen@squareup.com>
log actual error when GetSrvKeyspace fails
…est-transaction-timeout Add flag for extending the transaction timeout in vttestserver
…er could be managed by clusterwide etcd-operator Signed-off-by: ch3rub1m <ch3rub1m@foxmail.com>
Signed-off-by: ch3rub1m <ch3rub1m@foxmail.com>
Signed-off-by: Andres Taylor <antaylor@squareup.com>
Signed-off-by: Dan Kozlowski <koz@planetscale.com>
Signed-off-by: Dan Kozlowski <koz@planetscale.com>
…-containers Updating bootstrap containers for automated builds
…tcd-operator Add annotations value to EtcdCluster in helm chart
…actor Cleanup logs, comments and fix issue with rebuild keyspace in init_tablet
Surface consistent snapshot option in the UI for vertical splits
…ss-locks messager: avoid taking locks if there's no work to do
Make zookeeper version adjustable (ZK_VERSION env)
Add `-topo_zk_auth_file` flag
Return TabletManager.GetPermissions results in a consistent order
tableacls: remove deprecated -legacy-table-acl option from vttablet
Signed-off-by: dcadevil <dcadevil@126.com>
Signed-off-by: Vitalii <vit.stoyan@gmail.com>
Signed-off-by: Guido Iaquinti <giaquinti@slack-corp.com>
correct the parameter in the local example script
* Deprecate the concept of regions. * Favor aliases instead Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
Bump default Zookeper version to 3.4.14
Change a source for vtexplain image
Signed-off-by: Dan Kozlowski <koz@planetscale.com>
Signed-off-by: Dan Kozlowski <koz@planetscale.com>
Modify the bootstrap build to reference the correct ANT paths
|
is this blocked on getting vitessio#4767 merged? |
guidoiaquinti
approved these changes
Apr 3, 2019
guidoiaquinti
left a comment
guidoiaquinti
left a comment
There was a problem hiding this comment.
See @brirams comment, otherwise 👍
Author
|
@brirams - I think we don't need to block. I cherry-picked the relevant commit and I'm sorting out nit's to get that PR merged upstream. |
|
👍🏽👍🏽
🚢🚢🚢
…On Wed, Apr 3, 2019, 08:30 Rafael Chacon ***@***.***> wrote:
@brirams <https://github.com/brirams> - I think we don't need to block. I
cherry-picked the relevant commit and I'm sorting out nit's to get that PR
merged upstream.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#129 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/ABuUeqjAJLZ35fO_Q4cbGZGOFsAqKCc3ks5vdMkugaJpZM4cYoUt>
.
|
brirams
approved these changes
Apr 3, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
15 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Slack changes
Other changes
-topo_zk_auth_fileflag vitessio/vitess#4733Doc Changes