Skip to content

Refactor region to aliases#4767

Merged
rafael merged 3 commits intovitessio:masterfrom
tinyspeck:refactor-region-to-aliases
Apr 3, 2019
Merged

Refactor region to aliases#4767
rafael merged 3 commits intovitessio:masterfrom
tinyspeck:refactor-region-to-aliases

Conversation

@rafael
Copy link
Copy Markdown
Member

@rafael rafael commented Mar 29, 2019

Description

  • Deprecates regions inside CellInfo into a more flexible concept of aliases.
  • Much of functionality stays the same for now. In the future we could support overlapping aliases.

Tests

  • Updated existent tests to accommodate new concept.
  • Still pending a full integration test for this. Will add before this is ready to be merged.

@rafael rafael requested a review from sougou as a code owner March 29, 2019 23:59
@rafael rafael force-pushed the refactor-region-to-aliases branch from db65cc5 to 9e65e86 Compare March 30, 2019 00:03
* Deprecate the concept of regions.
* Favor aliases instead

Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
@rafael rafael force-pushed the refactor-region-to-aliases branch from 9e65e86 to 2c63167 Compare March 30, 2019 02:28
@rafael rafael force-pushed the refactor-region-to-aliases branch from f14ce7d to 1c7496a Compare April 2, 2019 00:06
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
Signed-off-by: Rafael Chacon <rafael@slack-corp.com>
@rafael rafael merged commit 0d5a6e9 into vitessio:master Apr 3, 2019
@rafael rafael deleted the refactor-region-to-aliases branch April 3, 2019 18:00
@deepthi deepthi mentioned this pull request Mar 24, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants