Skip to content

correct the error parameter in the local example script#4770

Merged
deepthi merged 1 commit intovitessio:masterfrom
dcadevil:master
Apr 2, 2019
Merged

correct the error parameter in the local example script#4770
deepthi merged 1 commit intovitessio:masterfrom
dcadevil:master

Conversation

@dcadevil
Copy link
Copy Markdown
Contributor

@dcadevil dcadevil commented Apr 1, 2019

The parameter min_healthy_rdonly_tablets in the example script should be changed to min_healthy_tablets.

Signed-off-by: dcadevil dcadevil@126.com

Signed-off-by: dcadevil <dcadevil@126.com>
@dcadevil dcadevil requested a review from sougou as a code owner April 1, 2019 08:01
Copy link
Copy Markdown
Collaborator

@deepthi deepthi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What problem is this PR trying to fix? It is not obvious.

@sougou
Copy link
Copy Markdown
Contributor

sougou commented Apr 1, 2019

Looks like this is related to #4759.
@systay : Looks like more things need to be changed: https://github.com/vitessio/vitess/search?p=2&q=min_healthy_rdonly_tablets&unscoped_q=min_healthy_rdonly_tablets
@rafael: heads up on possible UI breakage.

@systay
Copy link
Copy Markdown
Collaborator

systay commented Apr 2, 2019

@dcadevil thanks for catching and fixing this

@deepthi deepthi merged commit 35c8588 into vitessio:master Apr 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants