Make zookeeper version adjustable (ZK_VERSION env)#4734
Merged
sougou merged 1 commit intovitessio:masterfrom Mar 31, 2019
Merged
Make zookeeper version adjustable (ZK_VERSION env)#4734sougou merged 1 commit intovitessio:masterfrom
sougou merged 1 commit intovitessio:masterfrom
Conversation
deepthi
suggested changes
Mar 19, 2019
deepthi
approved these changes
Mar 19, 2019
f794b18 to
fb3f922
Compare
Signed-off-by: Adam Saponara <as@php.net>
Member
|
We should also add installation of ant to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch parameterizes the ZooKeeper version. Confirmed working with
ZK_VERSION=3.5.4-beta. There is a comment about updating theDockerfilebut I'm not so familiar with that.Not included in this patch but related:
The default config for
4lw.commands.whitelistis different in 3.5+. The above diff explicitly sets it to the default of 3.4. Without this, theruokhealthcheck fails. Alternatives: (a) parameterize (e.g.,{{.FourLetterWords}}), (b) ability to add arbitrary config, (c) something else?