messager: avoid taking locks if there's no work to do#4745
Merged
sougou merged 1 commit intovitessio:masterfrom Mar 31, 2019
Merged
messager: avoid taking locks if there's no work to do#4745sougou merged 1 commit intovitessio:masterfrom
sougou merged 1 commit intovitessio:masterfrom
Conversation
Signed-off-by: Michael Demmer <mdemmer@slack-corp.com>
sougou
approved these changes
Mar 31, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In reviewing #4739 I noticed that the txpool calls into the messager engine on every committed transaction with the list of new messages / changed messages.
For all cases in which the transaction did not actually change a messages table, the two lists are empty, but the messager engine still takes internal locks to process these empty lists.
It seems like this could cause unnecessary lock contention, so add an initial short-circuit check in case both lists are empty.