Skip to content

log actual error when GetSrvKeyspace fails#4757

Merged
deepthi merged 1 commit intovitessio:masterfrom
planetscale:ds-log-error
Mar 29, 2019
Merged

log actual error when GetSrvKeyspace fails#4757
deepthi merged 1 commit intovitessio:masterfrom
planetscale:ds-log-error

Conversation

@deepthi
Copy link
Copy Markdown
Collaborator

@deepthi deepthi commented Mar 28, 2019

Signed-off-by: deepthi deepthi@planetscale.com

@deepthi deepthi requested a review from sougou as a code owner March 28, 2019 01:17
@deepthi deepthi requested a review from rafael March 28, 2019 01:18
@rafael
Copy link
Copy Markdown
Member

rafael commented Mar 28, 2019

Thank you for this fix!

Per discussion in Slack, I think in this case we should squash these commits.

Signed-off-by: deepthi <deepthi@planetscale.com>
@deepthi
Copy link
Copy Markdown
Collaborator Author

deepthi commented Mar 28, 2019

Thank you for this fix!

Per discussion in Slack, I think in this case we should squash these commits.

Done.

@deepthi deepthi merged commit c91eff9 into vitessio:master Mar 29, 2019
@harshit-gangal harshit-gangal deleted the ds-log-error branch July 17, 2020 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants