Add annotations value to EtcdCluster in helm chart#4764
Merged
derekperkins merged 2 commits intovitessio:masterfrom Mar 30, 2019
Merged
Add annotations value to EtcdCluster in helm chart#4764derekperkins merged 2 commits intovitessio:masterfrom
derekperkins merged 2 commits intovitessio:masterfrom
Conversation
…er could be managed by clusterwide etcd-operator Signed-off-by: ch3rub1m <ch3rub1m@foxmail.com>
ch3rub1m
force-pushed
the
feature-cluster-wide-etcd-operator
branch
from
b8d29ce to
2b9a55a
Compare
derekperkins
requested changes
Mar 29, 2019
Member
derekperkins
left a comment
derekperkins
left a comment
There was a problem hiding this comment.
Looks good. Can you add some comments and maybe a link to values.yaml?
Signed-off-by: ch3rub1m <ch3rub1m@foxmail.com>
ch3rub1m
force-pushed
the
feature-cluster-wide-etcd-operator
branch
from
6af5a97 to
ee7bbef
Compare
Contributor
Author
Already done. |
derekperkins
approved these changes
Mar 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add annotations value to EtcdCluster in helm chart to make etcd cluster could be managed by clusterwide etcd-operator.
Implements #4758 .