Skip to content

fix tooltip on horizontal filter bar and sync#1

Merged
rtexelm merged 35 commits intomasterfrom
dev/filter/tooltip/75824
Oct 26, 2023
Merged

fix tooltip on horizontal filter bar and sync#1
rtexelm merged 35 commits intomasterfrom
dev/filter/tooltip/75824

Conversation

@rtexelm
Copy link
Copy Markdown
Owner

@rtexelm rtexelm commented Oct 26, 2023

SUMMARY

Allow SQL field in the Edit Dataset Modal to display entire queries without number of lines displayed being limited to 21. The field should not have any restriction on line length.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:
SQL field
AFTER:
SQL Field unbridled

TESTING INSTRUCTIONS

  1. Find or create a dataset that is powered by a long query.
  2. Click on the Edit Dataset action.
  3. Expand the SQL field.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

justinpark and others added 30 commits October 17, 2023 15:33
…erset-websocket (apache#25688)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Mikel Vuka <mikel.vuka@zalando.de>
…websocket (apache#25700)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…bsocket (apache#25701)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…websocket (apache#25689)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Sonia <sonia.gautam@agoda.com>
Co-authored-by: Mikel Vuka <mikel.vuka@zalando.de>
…cket (apache#25735)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@rtexelm rtexelm closed this Oct 26, 2023
@rtexelm rtexelm reopened this Oct 26, 2023
@rtexelm rtexelm changed the title fix(edit dataset modal): display full sql query in the sql field fix tooltip on horizontal filter bar and sync Oct 26, 2023
@rtexelm rtexelm merged commit 636a0f1 into master Oct 26, 2023
@rtexelm rtexelm deleted the dev/filter/tooltip/75824 branch October 26, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.