chore: Cleanup hostNamesConfig.js#25543
Merged
john-bodley merged 1 commit intomasterfrom Oct 17, 2023
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #25543 +/- ##
==========================================
+ Coverage 68.51% 69.13% +0.61%
==========================================
Files 1915 1915
Lines 75100 75100
Branches 8314 8314
==========================================
+ Hits 51455 51920 +465
+ Misses 21503 21038 -465
Partials 2142 2142
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 38 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
justinpark
approved these changes
Oct 6, 2023
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
Flexing my very limited frontend knowledge to cleanup checking for whether
bootstrapData.common.conf.SUPERSET_WEBSERVER_DOMAINSis defined.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
CI.
ADDITIONAL INFORMATION