Skip to content

refactor: use DATE_TRUNC for Elasticsearch time grain#25717

Merged
john-bodley merged 2 commits intoapache:masterfrom
mikelv92:refactor-elasticsearch-time-grain
Oct 20, 2023
Merged

refactor: use DATE_TRUNC for Elasticsearch time grain#25717
john-bodley merged 2 commits intoapache:masterfrom
mikelv92:refactor-elasticsearch-time-grain

Conversation

@mikelv92
Copy link
Copy Markdown
Contributor

SUMMARY

As discussed in #25683 this is a follow-up PR to refactor the Elasticsearch time grain expressions to use DATE_TRUNC instead of HISTOGRAM in order to have consistency.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

To verify that the time grains still work:

  • Create a database connection to an Elasticsearch cluster
  • Create an index in the Elasticsearch cluster. The index documents should have a date field and at least another field to be used in a metric
  • Create a dataset using the Elasticsearch database, and the choose the index created previously as the table
  • Create a time series chart and use the date field in the x axis
  • Select various time grains from the drop down menu and verify that the chart shows the time series data

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Copy Markdown
Member

@john-bodley john-bodley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mikelv92 for the refactor. LGTM.

@john-bodley john-bodley merged commit 9972ac6 into apache:master Oct 20, 2023
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
Co-authored-by: Mikel Vuka <mikel.vuka@zalando.de>
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 First shipped in 3.1.0 labels Mar 8, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Co-authored-by: Mikel Vuka <mikel.vuka@zalando.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 3.1.0 First shipped in 3.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants