chore: updated base DAO find_by_id to return generic type#25726
Merged
craig-rueda merged 1 commit intoapache:masterfrom Oct 23, 2023
Merged
chore: updated base DAO find_by_id to return generic type#25726craig-rueda merged 1 commit intoapache:masterfrom
craig-rueda merged 1 commit intoapache:masterfrom
Conversation
Antonio-RiveroMartnez
approved these changes
Oct 20, 2023
craig-rueda
approved these changes
Oct 23, 2023
craig-rueda
reviewed
Oct 23, 2023
| session: Session = None, | ||
| skip_base_filter: bool = False, | ||
| ) -> Model | None: | ||
| ) -> T | None: |
Member
There was a problem hiding this comment.
Can you force T to extend Model (if it already is that way, nvm)?
Author
There was a problem hiding this comment.
it is
superset/superset/daos/base.py
Line 35 in 26e5a69
cccs-rc
pushed a commit
to CybercentreCanada/superset
that referenced
this pull request
Mar 6, 2024
mistercrunch
added
🏷️ bot
vinothkumar66
pushed a commit
to vinothkumar66/superset
that referenced
this pull request
Nov 11, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION