fix(tags): +n tags for listview#25603
Conversation
|
/testenv TAGGING_SYSTEM=True |
|
/testenv up TAGGING_SYSTEM=true |
|
@hughhhh Ephemeral environment spinning up at http://34.221.218.192:8080. Credentials are |
| target="_blank" | ||
| rel="noreferrer" | ||
| > | ||
| {isLongTag ? `${name.slice(0, 20)}...` : name} |
There was a problem hiding this comment.
Could we put a const at the top holding this 20 ? I see we're using it in a few places and would be good to just update it once if needed. Or instead of having a isLongTag bool, why not just truncating the name altogether and use that when rendering? if it's a long tag we are always truncating it either way.
| ) : ( | ||
| tagElem | ||
| ); | ||
| return tagElem; |
There was a problem hiding this comment.
Do we have a test asserting we are rendering the "short" version of the tag when needed?
Antonio-RiveroMartnez
left a comment
Antonio-RiveroMartnez
left a comment
There was a problem hiding this comment.
lgtm, after fixing the tests it should be fine.
|
Ephemeral environment shutdown and build artifacts deleted. |
mistercrunch
added
🏷️ bot
3 participants
SUMMARY
Fix tooltip to render info about tag in collapse and overall naming even if it's long
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION