Skip to content

chore: bump pymssql version#25737

Merged
john-bodley merged 2 commits intoapache:masterfrom
gnought:patch-1
Oct 24, 2023
Merged

chore: bump pymssql version#25737
john-bodley merged 2 commits intoapache:masterfrom
gnought:patch-1

Conversation

@gnought
Copy link
Copy Markdown
Contributor

@gnought gnought commented Oct 23, 2023

SUMMARY

pymssql >=2.2.8 is required to compatible with cython v3 pymssql/pymssql#803

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

pymssql >=2.2.8 is required to compatible with cython v3 ttps://github.com/pymssql/pymssql/pull/803
@john-bodley john-bodley added the review:checkpoint Last PR reviewed during the daily review standup label Oct 23, 2023
Copy link
Copy Markdown
Member

@john-bodley john-bodley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gnought for the PR. I've left an inline comment, but could you also update the PR title/description to ensure CI passes.

Comment thread setup.py Outdated
@gnought gnought changed the title bump pymssql version chore: bump pymssql version Oct 24, 2023
@gnought
Copy link
Copy Markdown
Contributor Author

gnought commented Oct 24, 2023

@john-bodley fixed, all checks are passed.

@john-bodley john-bodley merged commit 419d122 into apache:master Oct 24, 2023
@gnought gnought deleted the patch-1 branch October 24, 2023 09:24
@john-bodley john-bodley removed the review:checkpoint Last PR reviewed during the daily review standup label Oct 26, 2023
cccs-rc pushed a commit to CybercentreCanada/superset that referenced this pull request Mar 6, 2024
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 3.1.0 First shipped in 3.1.0 labels Mar 8, 2024
vinothkumar66 pushed a commit to vinothkumar66/superset that referenced this pull request Nov 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 3.1.0 First shipped in 3.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants