feat: add database and schema names to dataset option#25569
feat: add database and schema names to dataset option#25569rusackas merged 7 commits intoapache:masterfrom
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
soniagtm
changed the title
|
Thanks for the PR! I'm curious what others (especially @kasiazjc) think about this. In particular, I'm wondering about users that have a whole lot of datasets. Adding the table/schema in the tooltip is AMAZING and (I think) uncontroversial. What I'm not sure about is if the table and schema are needed in the menu option listings, since they take up more vertical real estate, and will require more scrolling if the list is long. The tooltip seems sufficient to me, but I'm not sure ¯\_(ツ)_/¯ |
|
amazing @soniagtm and congrats on your first PR! @soniagtm I have some feedback about the metadata in the dropdown (schema and database) - I think it's 14px, can you change it to 12px? This way it all will be less cluttered and we'll get back a little bit of the precious real estate @rusackas :D For the context, @rusackas: Details in the dropdown solve a problem of quickly identifying which dataset is the one you're looking for (there are use cases of datasets with the same name, or users are just not familiar with them) or where does it come from, what is the context. That's why the request/solution was to make those details visible at all times. Also, this field is searchable, so it shouldn't be a problem with super long list. |
|
Another design option would be to replicate the database/schema UI elements we use in SQL Lab, etc. for consistency reasons, however it might be overkill, and/or a cumbersome UX. |
Yeah, I think it would be too much - we are actually thinking about using this pattern with metadata in the dropdown in other places, so for sure it wouldn't be a one time thing. |
|
Thanks to all of you for your feedback. I've reduced the font size as suggested, and also attached some screenshots to show how it looks now. Please have a look and let me know if there are any further improvements or adjustments needed :) Chart creation page |
This looks good to me! Thank you for all the changes :) |
michael-s-molina
left a comment
michael-s-molina
left a comment
There was a problem hiding this comment.
Thank you for the PR @soniagtm! I really think this brings a lot of value.
Currently, there are 2 concepts in Superset:
src/components contains components that are really generic and could be extracted to a library to be used outside of Superset.
src/features contains components that belong to the Superset domain and that are shared between multiple modules.
Given that we want to uniformly represent datasets throughout the application, the implementation of this new label should be moved to src/features/datasets and be reused in the native filters and chart creation.
|
One more UI issue. The labels are displayed partially after you select them. 
|
|
@soniagtm I verified that long database and schema names are truncated. Nice. 
We can improve the layout a little bit to use all the available space in some cases. 
|
Oh, good catch, thank you! From what we have defined in the design system - the metadata should not be displayed in the field |
We'll need to augment the |
|
I've moved the dataset label implementation to src/features/datasets as suggested and also fixed the UI issues found. BEFORE
AFTER
BEFORE
AFTER
Thanks! |
michael-s-molina
left a comment
michael-s-molina
left a comment
There was a problem hiding this comment.
Thanks for addressing the comments @soniagtm. It's looking great! I left some more suggestions.
michael-s-molina
left a comment
michael-s-molina
left a comment
There was a problem hiding this comment.
LGTM. Thank you for the awesome improvement @soniagtm and for patiently addressing all comments. Great job!
|
Thank you for your kind words and for helping me with my first PR! I'm really grateful for all the suggestions :) |
|
Echoing everyone here, thank you for this submission and all the effort that went into it! |
Co-authored-by: Sonia <sonia.gautam@agoda.com>
mistercrunch
added
🏷️ bot
Co-authored-by: Sonia <sonia.gautam@agoda.com>
7 participants
SUMMARY
This PR is created for adding database and schema names to the dataset option in the chart creation page and dashboard filter modal as described in Discussion: #25545.
The changes I have made will add database and schema names beneath each dataset name in the drop down list, as well as in the tooltip, so that users can identify the database and schema from which each dataset is created.
For datasets with a null schema name, the schema name in the tooltip label will be displayed as ‘Not defined’ instead.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE
Chart creation page
Dashboard filter modal
AFTER
Chart creation page
Dashboard filter modal
TESTING INSTRUCTIONS
To verify the changes made, please follow these steps:
Chart Creation Page:
(Assume that there exist some datasets that could be used to create a chart)
Dashboard Filter Modal:
(Assume that there are some dashboards to which you can apply filters)
ADDITIONAL INFORMATION