Korean Translation Progress #1
Comments
|
@tesseralis Hi. Thanks for kind explanation. |
|
For new translators 🏃, Please first check out #4 |
|
@taehwanno you should be able to edit the issue directly! Just click the ellipsis > "Edit" |
|
@tesseralis I tried, but I do not seem to have the authority :)
|
|
Ah! Sorry, I thought you were already one of the maintainers. I can add you to the list! You've done a lot of good work already finding all those resources! |
|
@tesseralis Sweet, Thanks. |
|
@tesseralis I am a contributor of React Crowdin project, but there is no progression for a long time at all. Is really able to work in crowdin project? And what's your plan for merging PRs & Crowdin translations? |
|
Hi @seungha-kim . Please see the original issue here: reactjs/react.dev#1605 Long story short, we decided that doing the translations directly on Github was the better approach since:
As for integrating Crowdin, we're encouraging people to use the Crowdin translations as a base. So you can just copy-paste your work from Crowdin, verify that it's up to date, and submit a pull request! |
|
I think there is no motivation to use Crowdin then :( I am likely to do job once using Git, rather than twice. |
|
PR submitted: #6 |
|
@chatoo2412 thank you for you PR! In the future, please let us know in a comment here when you're working on a page, so that we don't duplicate work with others. Also, we'd like to focus on the sections listed under "Core Pages"! |
|
@tesseralis I wanted to contribute using my prior work.
|
|
|
|
@hg-pyun @simsim0709 @gnujoow , as maintainers, could you keep track of this issue and assign people by editing the issue? |
I will 👍 |
|
@gnujoow is this document available to translate? |
@ENvironmentSet of course you can! please do 😄 |
|
I want to work on Hello World. |
|
@tesseralis yes, I will. Thanks |
I want to participate in the translation. Could you invite me please? 😊 |
|
@purelledhand Oh, Did you meant translation of refs-and-the-dom document? |
|
Following React Top-level API, I will translate the next document, React.Component |
|
@cadenzah you got it! |
|
@tesseralis I’ll take |
|
@junsikshim 넵 시작하셔도 좋을 것 같습니다. |
|
@hg-pyun |
|
@nh0627 Blog와 Community도 있습니다.
#272 를 진행해 주셔도 좋을 것 같습니다 :) |
|
@hg-pyun 272작업해보고 나머지 둘도 차근차근해서 PR올려볼게요~ |
|
@hg-pyun 전에 hoc가 계속 풀리퀘스트에 있길래 조금 작업해서 올려서 통과되었었습니다. |
|
@dev-hikun 이 부분은 먼저 배정받으신 분을 기준으로 조율하는게 맞아보여요 ㅎㅎ 배정 받으신 분의 작업 진행상황에 따라 #286 은 반영되지 않을 수 있다는 점을 미리 알려드립니다. @junsikshim 안녕하세요. Higher Order Components 번역 관련 진행상황을 공유받을 수 있을까요? 아직 시작하지 않으셨거나, 번역이 많이 되지 않은 상태라면 #286 리뷰를 대신 부탁드릴까 하는데 편하게 의견 부탁드릴게요! |
|
@taehwanno 40% 정도 진행하긴 했는데, 다른 분께 넘겨도 상관없을 것 같습니다. |
|
@junsikshim 감사합니다! 혹시 n동이시라면 커피한잔 사드리겠습니다 하하 ;-) |
|
@taehwanno @junsikshim @hg-pyun #286 리뷰 주신 것들 토대로 적용하였습니다. 시간 나실 때 재리뷰 부탁드리겠습니다 :-) |
|
안녕하세요! 한국어 번역에 기여하고 싶습니다. 혹시 맡을 수 있는 부분이 아직 있을까요? |
|
@hannah-developer 모든 페이지가 번역이 완료된 상태라서 #272 이슈 한번 살펴보시거나 이미 번역된 페이지 중 어색한 부분 개선해보는게 좋아보여요! |
|
Code Editor와 Code Example 파트를 번역한 PR을 업로드했습니다. :) |
|
https://ko.reactjs.org/docs/legacy-context.html 혹시 이 페이지는 새로 추가된 페이지일까요.? |
|
안녕하세요, 이슈에 참여 중인 분들께 알려드립니다. |
|
close due to #374 |
Translate document to korean (Rendering Lists)
|
https://translations.react.dev/ 에 한국어 진행상황만 누락되어있는데, 이 이슈가 닫혀서 그런것 같습니다. Reopen 요청드립니다.
출처: https://github.com/reactjs/translations.react.dev 위 내용은 translations.react.dev의 번역 진행사항을 가져오는 코드 중 일부인데 getProgressList 메서드 내에서 graphql API를 이용하여 깃헙의 ISSUE 내에 Translation Progress이라는 제목을 가지면서 open 상태인 데이터를 가져오게 합니다. 즉, 이 이슈가 closed 상태라 해당 페이지에서 데이터를 가져오지 못하여 나타나지 않는것 같습니다. 이 Issue를 Reopen하면 다시 정상적으로 나타날것 같습니다. |
|
오오 저도 translations.react.dev 이슈 확인하면서 korea 번역본만 나타나지 않는게 의아했는데 이런 문제였군요 바로 오픈하도록 하겠습니다. 좋은 지적 감사합니다🙇♂️ @hcooch2ch3 github workflow 내용 확인하니 하루에 한번씩 동기화 작업이 진행되는 것 같은데, translations.react.dev 번역 진행 사항 이슈로 현재 이슈 다시 오픈하도록 하겠습니다. |
|
@lumirlumir 
원인을 찾아보니, 이 이슈의 체크리스트는 예전 버전 체크리스트라 translations.react.dev에 정상적으로 퍼센테이지가 반영되지 않는것 같습니다. 다음 링크 (https://github.com/reactjs/translations.react.dev/blob/main/PROGRESS.template.md)의 마크다운 파일로 새로 수정하거나, 임의로 function getLangProgress(lang, issue) {
const { body, createdAt, lastEditedAt = createdAt, ...issueProps } = issue
let coreCompletion = 0;
let otherCompletion = 0;
body.split(/^##\s+/gm).forEach(section => {
const [heading, ...content] = section.split('\n')
const items = content.filter(line => {
return /[-*] *\[[ x]\]/.test(line)
})
const finishedItems = items.filter(line => /[-*] \[x\]/.test(line));
if (/MAIN_CONTENT/.test(heading)) {
coreCompletion = finishedItems.length / items.length;
} else if (/SECONDARY_CONTENT/.test(heading)) {
otherCompletion = finishedItems.length / items.length;
}
});
return {
...lang,
...issueProps,
createdAt,
lastEditedAt,
coreCompletion,
otherCompletion,
}
}위 코드는 진행상황률을 계산하는 메서드 인데, 간단하게 수정한다면, |
|
해결 완료하였습니다👍 이제 완료율 100%로 해서 페이지에 정상적으로 표시됩니다
진작 100%로 표기되었어야 하는데, 좀 늦은감이 없지 않아 있네요. react.dev에도 아래와 같이 PR 넣어놨으니 영문 공식 문서에서도 곧 정상 반영되지 않을까 합니다. 신경써주셔서 감사합니다🙇♂️ |
and others
For New Translators
To translate a page:
Before contributing, read the glossary and style guide (once they exist) to understand how to translate various technical and React-specific terms.
Please be prompt with your translations! If you find that you can't commit anymore, let the maintainers know so they can assign the page to someone else.
For Maintainers
When someone volunteers, edit this issue with the username of the volunteer, and with the PR. Ex:
When PRs are merged, make sure to mark that page as completed like this:
This ensures your translation's progress is tracked correctly at https://translations.react.dev/.
Main Content
To do before releasing as an "official" translation. Please translate these pages first.
Note that each section has an index page, which needs to be translated too.
Learn React
Quick Start
Installation
Describing the UI
Adding Interactivity
Managing State
Escape Hatches
API Reference
react: HooksuseCallbackuseContextuseDebugValueuseDeferredValueuseEffectuseIduseImperativeHandleuseInsertionEffectuseLayoutEffectuseMemouseReduceruseRefuseStateuseSyncExternalStoreuseTransitionreact: Components<Fragment> (<>)<Profiler><StrictMode><Suspense>react: APIscreateContextforwardReflazymemostartTransitionreact-dom: Components<div>)<input><option><progress><select><textarea>react-dom: APIscreatePortalflushSyncfindDOMNodehydraterenderunmountComponentAtNodereact-dom/client: Client APIscreateRoothydrateRootreact-dom/server: Server APIsrenderToNodeStreamrenderToPipeableStreamrenderToReadableStreamrenderToStaticMarkuprenderToStaticNodeStreamrenderToStringNavigation and UI
We suggest to leave most of the UI translation until the end. We plan to do some invasive changes to the website folder layout and components, so postponing this until your translation is almost complete would make it easier to merge the changes from our side later. It might make sense to translate the homepage above the fold early, but leave the rest for later. As individual pages get translated, you can change the page titles in the corresponding sidebar files. Finally, when you're translating the navigation, make sure to test both desktop and mobile layouts.
HomeContent.js)src/sidebar*.json)TopNav.tsx)When You're Ready...
After everything above is translated, add your language to
deployedLanguagesinSeo.tsxof the original reactjs/react.dev repository.Secondary Content
These API pages should ideally be translated too, but they're less urgent and can be done after the others:
ChildrencloneElementComponentcreateElementcreateFactorycreateRefisValidElementPureComponentOptional Content
These aren't the main translation targets, but if you'd like to do them, feel free to expand the list to include their subpages:
Maintainer List
This translation is maintained by:
If you want to become a maintainer, ask them to add you. If the original maintainers are no longer responsive, raise an issue in the main translations repository.
Click here to see reactjs.org legacy progress
Maintainer List
For New Translators
To translate a page:
Before contributing, read the glossary and this wiki page to understand how to translate various technical and React-specific terms.
Please be prompt with your translations! If you find that you can't commit any more, let the maintainers know so they can assign the page to someone else.
Please join in React Korea Slack #translation channel if you are interested in the translation.
For maintainers
When someone volunteers, edit this issue with the username of the volunteer, and with the PR. Ex:
When PRs are merged, make sure to mark that page as completed!
Core Pages
To do before releasing as an "official" translation. Please translate these pages first.
Basics
API Reference
Navigation
These are the navigation links that appears in the sidebar. Possibly wait until
the corresponding sections are translated to do these.
Next Steps
These are the next most important translations, ordered by importance:
Installation
Hooks
Everyone is hooked on hooks! People are really excited for these and it would be great for them to be translated.
Warnings
These are the pages that you get when you click the links in the console (e.g. https://reactjs.org/warnings/dont-call-proptypes.html). People tend to search these, so please don't translate the error message itself.
Advanced Guides
@gnujoow@dev-hikun)higher-order-components (partial) #187Translated HOC Page #286FAQ
Contributing
Priority: Low
Components
Components in
src/componentsthat have some text in them.Additional Translations
These are not the primary translation targets.
Translations added after this issue creation
Testing
Concurrent Mode (Experimental)
The text was updated successfully, but these errors were encountered: