Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨KOREAN(ko.react.dev) Translation Completed #7185

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

lumirlumir
Copy link
Contributor

@lumirlumir lumirlumir commented Sep 24, 2024

Hello, I am currently the collaborator of ko.react.dev.

Although the translation for ko.react.dev was completed some time ago, we did not reflect this progress in translations.react.dev and in finishedTranslations.ts within the react.dev repository.

We have now completed all translations, except for the newly added features after the list provided in PROGRESS.template.md.

image

Copy link

vercel bot commented Sep 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
19-react-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 24, 2024 9:20am
react-dev ✅ Ready (Inspect) Visit Preview Sep 24, 2024 9:20am

Copy link

Size changes

📦 Next.js Bundle Analysis for react-dev

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Five Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load
/404 104.33 KB (🟡 +4 B) 208.63 KB
/500 104.33 KB (🟡 +4 B) 208.63 KB
/[[...markdownPath]] 106.18 KB (🟡 +4 B) 210.48 KB
/errors 104.54 KB (🟡 +4 B) 208.84 KB
/errors/[errorCode] 104.52 KB (🟡 +4 B) 208.82 KB
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

Next to the size is how much the size has increased or decreased compared with the base branch of this PR. If this percentage has increased by 10% or more, there will be a red status indicator applied, indicating that special attention should be given to this.

@lumirlumir lumirlumir changed the title KOREAN(ko.react.dev) Translation Completed ✨KOREAN(ko.react.dev) Translation Completed Sep 24, 2024
@rammba
Copy link
Contributor

rammba commented Sep 24, 2024

Great work @lumirlumir, as a fellow translator for Serbian I must congratulate you and your team on this achievement.
I wish you all the best with maintaining and impoving translations in the future.

@rickhanlonii rickhanlonii merged commit fe37c42 into reactjs:main Sep 29, 2024
6 checks passed
@rickhanlonii
Copy link
Member

@lumirlumir thank you so much, and congrats to you and the folks that helped out to get to this milestone!

@lumirlumir lumirlumir deleted the patch-1 branch September 30, 2024 04:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants