Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translation of Advanced Guides > Portals #131

Merged
merged 4 commits into from
Jun 11, 2019
Merged

Translation of Advanced Guides > Portals #131

merged 4 commits into from
Jun 11, 2019

Conversation

hapumee
Copy link
Contributor

@hapumee hapumee commented May 29, 2019 •
edited
Loading

@netlify
Copy link

netlify bot commented May 29, 2019 •
edited
Loading

Deploy preview for ko-reactjs-org ready!

Built with commit 9125b40

https://deploy-preview-131--ko-reactjs-org.netlify.com

hg-pyun
hg-pyun reviewed May 29, 2019
View reviewed changes
content/docs/portals.md Outdated Show resolved Hide resolved
content/docs/portals.md Outdated Show resolved Hide resolved
@tesseralis tesseralis mentioned this pull request May 29, 2019
Open
@hapumee
Copy link
Contributor Author

hapumee commented May 30, 2019

커맨트 주신 내용은 수정/반영하였고, 해당 conversation은 resolve 했습니다.

hg-pyun
hg-pyun approved these changes May 31, 2019
View reviewed changes
Copy link
Member

@hg-pyun hg-pyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

다른분들도 리뷰 부탁드립니다!

@simsim0709 simsim0709 self-requested a review June 11, 2019 04:20
simsim0709
simsim0709 approved these changes Jun 11, 2019
View reviewed changes
Copy link
Collaborator

@simsim0709 simsim0709 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고 많으셨어요~ 👍

@simsim0709 simsim0709 merged commit 7086a14 into reactjs:master Jun 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hg-pyun hg-pyun hg-pyun approved these changes

@simsim0709 simsim0709 simsim0709 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hapumee @simsim0709 @hg-pyun @taehwanno @youngsunmin