Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translate Composition vs Inheritance #22

Merged
merged 5 commits into from
Feb 28, 2019
Merged

Translate Composition vs Inheritance #22

merged 5 commits into from
Feb 28, 2019

Conversation

hewonjeong
Copy link
Contributor

@hewonjeong hewonjeong commented Feb 12, 2019

Please let me know if you find any mistakes 🙇

References
https://reactjs-org-ko.netlify.com/docs/composition-vs-inheritance.html


## Containment {#containment}
## 컴포넌트에서 다른 컴포넌트를 담기 {#containment}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

containment는 (좋지 않은 일의) 방지[억제], (다른 국가의 무력에 대한) 견제, 격납 등으로 해석하는데, 격납이라고만 해석하기엔 의미가 전달되는 것 같지 않아 내용을 조금 풀어서 컴포넌트에서 다른 컴포넌트를 담기라고 번역했습니다.

@ENvironmentSet ENvironmentSet mentioned this pull request Feb 12, 2019
content/docs/composition-vs-inheritance.md Outdated Show resolved Hide resolved
content/docs/composition-vs-inheritance.md Outdated Show resolved Hide resolved
content/docs/composition-vs-inheritance.md Outdated Show resolved Hide resolved
content/docs/composition-vs-inheritance.md Outdated Show resolved Hide resolved
content/docs/composition-vs-inheritance.md Outdated Show resolved Hide resolved
content/docs/composition-vs-inheritance.md Outdated Show resolved Hide resolved
content/docs/composition-vs-inheritance.md Outdated Show resolved Hide resolved
content/docs/composition-vs-inheritance.md Outdated Show resolved Hide resolved
@hewonjeong
Copy link
Contributor Author

리뷰 반영하였습니다. 리뷰 남겨주신 분들 감사합니다🙇‍♂️

Copy link
Collaborator

@simsim0709 simsim0709 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! 👍

@netlify
Copy link

netlify bot commented Feb 28, 2019

Deploy preview for ko-reactjs-org ready!

Built with commit 0769121

https://deploy-preview-22--ko-reactjs-org.netlify.com

@simsim0709 simsim0709 merged commit 3762413 into reactjs:master Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants