Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translate Strict Mode #47

Merged
merged 4 commits into from
May 28, 2019
Merged

Translate Strict Mode #47

merged 4 commits into from
May 28, 2019

Conversation

hiddenest
Copy link
Contributor

@hiddenest hiddenest commented Feb 25, 2019 •
edited by simsim0709
Loading

Progress

@hiddenest hiddenest mentioned this pull request Feb 25, 2019
Open
@netlify
Copy link

netlify bot commented Feb 25, 2019 •
edited
Loading

Deploy preview for ko-reactjs-org ready!

Built with commit 9850306

https://deploy-preview-47--ko-reactjs-org.netlify.com

gnujoow
gnujoow requested changes Mar 6, 2019
View reviewed changes
Copy link
Member

@gnujoow gnujoow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

몇가지 띄어쓰기 오류가 있습니다.

content/docs/strict-mode.md Outdated Show resolved Hide resolved
content/docs/strict-mode.md Outdated Show resolved Hide resolved
content/docs/strict-mode.md Outdated Show resolved Hide resolved
@hiddenest
Copy link
Contributor Author

@gnujoow 요청해주신 변경사항 모두 반영하였습니다 :) 리뷰 감사합니다!

taehwanno
taehwanno reviewed Mar 7, 2019
View reviewed changes
content/docs/strict-mode.md Outdated Show resolved Hide resolved
content/docs/strict-mode.md Outdated Show resolved Hide resolved
content/docs/strict-mode.md Outdated Show resolved Hide resolved
content/docs/strict-mode.md Outdated Show resolved Hide resolved
content/docs/strict-mode.md Outdated Show resolved Hide resolved
content/docs/strict-mode.md Outdated Show resolved Hide resolved
content/docs/strict-mode.md Outdated Show resolved Hide resolved
content/docs/strict-mode.md Outdated Show resolved Hide resolved
content/docs/strict-mode.md Outdated Show resolved Hide resolved
content/docs/strict-mode.md Outdated Show resolved Hide resolved
@gnujoow
Copy link
Member

gnujoow commented Apr 11, 2019

@hiddenest 진행상황을 알 수 있을까요?

@simsim0709 simsim0709 mentioned this pull request May 24, 2019
Closed
@simsim0709 simsim0709 self-requested a review May 28, 2019 00:25
simsim0709
simsim0709 approved these changes May 28, 2019
View reviewed changes
Copy link
Collaborator

@simsim0709 simsim0709 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다. 리뷰 사항 반영은 제가 직접 했습니다. 👍

hg-pyun
hg-pyun approved these changes May 28, 2019
View reviewed changes
Copy link
Member

@hg-pyun hg-pyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다.

@taehwanno taehwanno merged commit 26663c6 into reactjs:master May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hg-pyun hg-pyun hg-pyun approved these changes

@simsim0709 simsim0709 simsim0709 approved these changes

@taehwanno taehwanno Awaiting requested review from taehwanno

@gnujoow gnujoow Awaiting requested review from gnujoow

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hiddenest @gnujoow @taehwanno @simsim0709 @hg-pyun