Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Translating "nav.yml" to Korean #189

Merged
merged 6 commits into from
Nov 22, 2019
Merged

Translating "nav.yml" to Korean #189

merged 6 commits into from
Nov 22, 2019

Conversation

rkdmf1026
Copy link
Contributor

@rkdmf1026 rkdmf1026 commented Nov 18, 2019 •
edited
Loading

@netlify
Copy link

netlify bot commented Nov 18, 2019 •
edited
Loading

Deploy preview for ko-reactjs-org ready!

Built with commit d06491e

https://deploy-preview-189--ko-reactjs-org.netlify.com

gnujoow
gnujoow previously approved these changes Nov 19, 2019
View reviewed changes
Copy link
Member

@gnujoow gnujoow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다.

현재 번역이 진행중인 문서도 있는것 같아 해당 문서와 nav.yml의 제목이 일치하는지 한번 확인해주시면 감사하겠습니다.

todo

  • 새로 추가된 문서의 제목과 nav.yml의 제목 일치 확인

@rkdmf1026
Copy link
Contributor Author

Concurrent mode의 경우에는 #182 와 #186 의 용어 번역차이가 있어 #182 기준으로 제목을 번역하였습니다.
testing의 경우에는 이미 merge된 부분에서 'testing'을 '테스팅'이라 번역하여 이를 기준으로 번역하였습니다.

taehwanno
taehwanno requested changes Nov 20, 2019
View reviewed changes
content/docs/nav.yml Outdated Show resolved Hide resolved
taehwanno
taehwanno previously approved these changes Nov 21, 2019
View reviewed changes
Copy link
Member

@taehwanno taehwanno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

공백 하나 직접 추가했습니다. 고생하셨습니다 ㅎㅎ

@taehwanno
Copy link
Member

API Reference가 API 참고서로 번역되어 있어서 통일시키기 위해 추가 커밋했습니다.

@taehwanno taehwanno mentioned this pull request Nov 21, 2019
Merged
6 tasks
hg-pyun
hg-pyun approved these changes Nov 22, 2019
View reviewed changes
Copy link
Member

@hg-pyun hg-pyun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@taehwanno taehwanno merged commit fad39de into reactjs:master Nov 22, 2019
@tesseralis tesseralis mentioned this pull request Nov 22, 2019
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gnujoow gnujoow gnujoow approved these changes

@hg-pyun hg-pyun hg-pyun approved these changes

@taehwanno taehwanno taehwanno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rkdmf1026 @taehwanno @hg-pyun @gnujoow