Add release notes for 0.246#15602
Conversation
|
Additional release notes for me: |
There was a problem hiding this comment.
What does this mean from a user perspective @rongrong?
There was a problem hiding this comment.
This comment has not been addressed yet.
There was a problem hiding this comment.
It means if user use function namespace manager presto server might fail to start failing with injection error.
There was a problem hiding this comment.
What does this mean? Is there anything the user needs to do to enable this feature?
There was a problem hiding this comment.
Guideline for the start of the line: https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines#order-of-changes.
We should rephrase to
Add support ...
|
@caithagoras can't add you as a reviewer because the PR is under your name, but the release notes are ready for review. |
There was a problem hiding this comment.
* Add a minimum value of 30 seconds to the configuration property ``query.min-expire-age``.
There was a problem hiding this comment.
Guideline for the start of the line: https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines#order-of-changes.
We should rephrase to
Add support ...
There was a problem hiding this comment.
double back quotes. Please also update everywhere else in the doc for keywords.
``ORDER BY``
There was a problem hiding this comment.
Remove extra whitespace.
``GENERIC_INTERNAL_ERRORS``
There was a problem hiding this comment.
Add a period (".") at the end of the line.
There was a problem hiding this comment.
We should rephrase to
Improve ...
There was a problem hiding this comment.
Let's include all changes that starts with "Add" and "Improve".
There was a problem hiding this comment.
I don't think there is anything that major. lets remove this section for this release
There was a problem hiding this comment.
int -> integer, temp -> temporary
There was a problem hiding this comment.
what does this mean - can the author clarify this ?
There was a problem hiding this comment.
I don't think there is anything that major. lets remove this section for this release
|
@cocozianu can you squash all the commits together? |
|
Please squash all commits into 1. We don't use multiple commits for retaining history. https://thoughtbot.com/blog/git-interactive-rebase-squash-amend-rewriting-history |
1c8ab8c to
4426a4d
Compare
4426a4d to
65d4746
Compare
Missing Release Notes
Bhavani Hari
Emy Sun
George Wang
shenh062326
Extracted Release Notes
15313that would cause queries to fail when using upper case in SQL function catalog schema names.query.min-expire-ageconfiguration parameter.All Commits