Skip to content

Ensure nullable partitioning column is handled properly#15470

Merged
highker merged 1 commit intoprestodb:masterfrom
fgwang7w:15446
Dec 8, 2020
Merged

Ensure nullable partitioning column is handled properly#15470
highker merged 1 commit intoprestodb:masterfrom
fgwang7w:15446

Conversation

@fgwang7w
Copy link
Member

@fgwang7w fgwang7w commented Nov 23, 2020

== RELEASE NOTE ==

Hive changes
* Fix dynamic pruning failures for joining on null keys in hive partition

@fgwang7w
Copy link
Member Author

resolve #15446

Copy link
Collaborator

@kewang1024 kewang1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Can you merge those two commits into one commit?
  2. Is it to solve a general issue or just for dynamic filtering?
  3. Can you add integration test as well? (Example like:TestHiveDistributedJoinQueriesWithDynamicFiltering, TestHiveDistributedJoinQueriesWithDynamicFilteringAndFilterPushdown )

@fgwang7w
Copy link
Member Author

  1. Can you merge those two commits into one commit?
  2. Is it to solve a general issue or just for dynamic filtering?
  3. Can you add integration test as well? (Example like:TestHiveDistributedJoinQueriesWithDynamicFiltering, TestHiveDistributedJoinQueriesWithDynamicFilteringAndFilterPushdown )

Thanks for reviewing the PR.

  1. done
  2. this issue happends when dynamic filtering is on, so the fix is to solve for DF only
  3. TestHiveDistributedJoinQueriesWithDynamicFiltering.testJoinOnNullPartitioning is added for integration test.

@fgwang7w
Copy link
Member Author

fgwang7w commented Dec 3, 2020

@kewang1024 could you please help review the code? it'd be ideal if the code can be merged in the upcoming release, thanks

@fgwang7w fgwang7w closed this Dec 3, 2020
@fgwang7w fgwang7w reopened this Dec 3, 2020
@fgwang7w
Copy link
Member Author

fgwang7w commented Dec 4, 2020

hi@highker could you please merge this fix? I'm running some benchmark testing with DF on and this is blocking in many tcs, thx

Copy link
Collaborator

@kewang1024 kewang1024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1.For release note, it's not a general change, only hive change.
remove == NO RELEASE NOTE ==
2.Change the commit and release message to something like:
Fix dynamic pruning for null keys in hive partition

@kewang1024
Copy link
Collaborator

Also the release note please.
@highker can you help review this PR as well?

@highker highker self-assigned this Dec 7, 2020
@fgwang7w fgwang7w force-pushed the 15446 branch 2 times, most recently from c9e8a5c to 8cd223c Compare December 7, 2020 05:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants