Ensure nullable partitioning column is handled properly#15470
Merged
highker merged 1 commit intoprestodb:masterfrom Dec 8, 2020
Merged
Ensure nullable partitioning column is handled properly#15470highker merged 1 commit intoprestodb:masterfrom
highker merged 1 commit intoprestodb:masterfrom
Conversation
Member
Author
|
resolve #15446 |
kewang1024
requested changes
Nov 27, 2020
Collaborator
There was a problem hiding this comment.
- Can you merge those two commits into one commit?
- Is it to solve a general issue or just for dynamic filtering?
- Can you add integration test as well? (Example like:TestHiveDistributedJoinQueriesWithDynamicFiltering, TestHiveDistributedJoinQueriesWithDynamicFilteringAndFilterPushdown )
Member
Author
Thanks for reviewing the PR.
|
57e27f3 to
3bce125
Compare
Member
Author
|
@kewang1024 could you please help review the code? it'd be ideal if the code can be merged in the upcoming release, thanks |
Member
Author
|
hi@highker could you please merge this fix? I'm running some benchmark testing with DF on and this is blocking in many tcs, thx |
kewang1024
approved these changes
Dec 6, 2020
Collaborator
kewang1024
left a comment
There was a problem hiding this comment.
1.For release note, it's not a general change, only hive change.
remove == NO RELEASE NOTE ==
2.Change the commit and release message to something like:
Fix dynamic pruning for null keys in hive partition
presto-hive/src/main/java/com/facebook/presto/hive/HiveUtil.java
Outdated
Show resolved
Hide resolved
Collaborator
|
Also the release note please. |
highker
approved these changes
Dec 7, 2020
...e/src/test/java/com/facebook/presto/hive/statistics/TestMetastoreHiveStatisticsProvider.java
Outdated
Show resolved
Hide resolved
...c/test/java/com/facebook/presto/hive/TestHiveDistributedJoinQueriesWithDynamicFiltering.java
Outdated
Show resolved
Hide resolved
c9e8a5c to
8cd223c
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.