Split large pages in TempSingleStreamSpiller#15529
Merged
rschlussel merged 1 commit intoprestodb:masterfrom Dec 17, 2020
Merged
Split large pages in TempSingleStreamSpiller#15529rschlussel merged 1 commit intoprestodb:masterfrom
rschlussel merged 1 commit intoprestodb:masterfrom
Conversation
Contributor
Author
|
Previously did this for the FileSingleStreamSpiller #15403 |
This prevents int overflow when serializing pages, since page serialization requires the page size in bytes to fit in an integer. Was already added for FileSingleStreamSpiller at commit f61df1b
rschlussel
force-pushed
the
split-tempfs-spill
branch
from
83e945d to
d62a500
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This prevents int overflow when serializing pages, since page
serialization requires the page size in bytes to fit in an integer.
Test plan - None