Add release notes for 0.245#15499
Conversation
|
@pettyjamesm @shixuan-fan The release note for #15393 doesn't follow the release note guidelines here https://github.com/prestodb/presto/wiki/Release-Notes-Guidelines#phrasing |
|
@caithagoras @daniel-ohayon Can you please add more detail about #15444 ? |
39ecd8e to
caf1271
Compare
Updated the PR release notes section to mention the specific CLI flag and server side configuration property. |
36171f9 to
e9fc296
Compare
Updated the PR release note with the function signature |
There was a problem hiding this comment.
- Add :func:
enum_keyto get the key corresponding to an enum value
There was a problem hiding this comment.
Are you advocating for not showing the signature?
There was a problem hiding this comment.
``Improve parquet metadata reader by preloading data and reducing the number of reads` - I don't think we should dig too much into the implementation details. We should just link to the issue/pr
There was a problem hiding this comment.
The release note generation logic doesn't link to PRs. I added the link for this one, but generally what are we doing? Seems like we should do it automatically.
rschlussel
left a comment
There was a problem hiding this comment.
squash all the fixes into the 0.245 release notes commit.
|
lgtm |
3644cb3 to
d6f6870
Compare
|
@rongrong tagging you to review the warning I added. |
d6f6870 to
cbfd2bd
Compare
|
@aweisberg docs build is failing. |
There was a problem hiding this comment.
Missing period at the end of the line.
|
There are still Travis build failure due to Sphinx syntax. You can figure out why it is failing by |
There was a problem hiding this comment.
I ran make with Sphinx 2.4.0 and it gives me warning about this line.
WARNING: py:func reference target not found: enum_key
We either need to document the function, or do
``enum_key``
as a temporary workaround to not reference the function.
cbfd2bd to
103fc49
Compare
|
Merged #15499, thanks for the contribution! |
Missing Release Notes
Mayank Garg
Extracted Release Notes
15424).15424).All Commits