Inject null provider when thrift execution is not needed#15501
Merged
rongrong merged 1 commit intoprestodb:masterfrom Dec 8, 2020
Merged
Inject null provider when thrift execution is not needed#15501rongrong merged 1 commit intoprestodb:masterfrom
rongrong merged 1 commit intoprestodb:masterfrom
Conversation
rongrong
force-pushed
the
fix-injection
branch
3 times, most recently
from
0a9a5cf to
2b1d3ed
Compare
wenleix
reviewed
Dec 8, 2020
Contributor
There was a problem hiding this comment.
Can we just make this Optional? :)
Contributor
There was a problem hiding this comment.
I would also prefer Optional here.
Contributor
There was a problem hiding this comment.
Have you not pushed yet since it's still @nullable?
Contributor
Author
There was a problem hiding this comment.
Decided to go with nullable for injection but change the member variable to optional. This for the most part avoids potential bugs of having a nullable variable, and doesn't require me to figure out how to inject Optional 😂
caithagoras
approved these changes
Dec 8, 2020
Contributor
There was a problem hiding this comment.
I would also prefer Optional here.
rongrong
force-pushed
the
fix-injection
branch
from
2b1d3ed to
324edc3
Compare
wenleix
approved these changes
Dec 8, 2020
5 tasks
This was referenced Jan 28, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test plan - run Presto server