Support driver level plan in fragment result caching#15550
Merged
shixuan-fan merged 2 commits intoprestodb:masterfrom Dec 23, 2020
Merged
Support driver level plan in fragment result caching#15550shixuan-fan merged 2 commits intoprestodb:masterfrom
shixuan-fan merged 2 commits intoprestodb:masterfrom
Conversation
shixuan-fan
force-pushed
the
driver_frc
branch
from
a2a9436 to
cb062fb
Compare
highker
reviewed
Dec 22, 2020
highker
left a comment
highker
left a comment
There was a problem hiding this comment.
two questions on CanonicalPlanGenerator
presto-main/src/main/java/com/facebook/presto/sql/planner/CanonicalPlanGenerator.java
Outdated
Show resolved
Hide resolved
presto-main/src/main/java/com/facebook/presto/sql/planner/CanonicalPlanGenerator.java
Outdated
Show resolved
Hide resolved
shixuan-fan
force-pushed
the
driver_frc
branch
from
cb062fb to
ff25600
Compare
highker
approved these changes
Dec 23, 2020
This would enable fragment result caching on the leaf driver when there are multiple drivers in the lifespan introduced by local exchange, for example, intermediate aggregation
shixuan-fan
force-pushed
the
driver_frc
branch
from
ff25600 to
0262da3
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test plan - Added unit test. Will also do verifier correctness test