Require min 30s query.min-expire-age#15585
Merged
wenleix merged 1 commit intoprestodb:masterfrom Jan 5, 2021
Merged
Conversation
mayankgarg1990
approved these changes
Jan 5, 2021
Contributor
|
merged #15585, thanks for the contribution! |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tested manually with TestQueryManagerConfig to make sure the minimum is enforced. 29 seconds fails, 30 seconds works.
This turns out to be important when clients are on higher latency connections. The client library may poll for status for a query that has completed and the coordinator may have expired the completed query causing the client library to generate an error.