Reduce parquet metadata read request count#15421
Merged
zhenxiao merged 1 commit intoprestodb:masterfrom Nov 12, 2020
Merged
Conversation
zhenxiao
reviewed
Nov 12, 2020
Collaborator
zhenxiao
left a comment
zhenxiao
left a comment
There was a problem hiding this comment.
hi @pettyjamesm nice work
looks good to me. Just a few minor issues
presto-parquet/src/main/java/com/facebook/presto/parquet/cache/MetadataReader.java
Outdated
Show resolved
Hide resolved
presto-parquet/src/main/java/com/facebook/presto/parquet/cache/MetadataReader.java
Outdated
Show resolved
Hide resolved
presto-parquet/src/main/java/com/facebook/presto/parquet/cache/MetadataReader.java
Outdated
Show resolved
Hide resolved
presto-parquet/src/main/java/com/facebook/presto/parquet/cache/MetadataReader.java
Outdated
Show resolved
Hide resolved
Attempts to reduce the number of reads required for parquet footers by pre-reading up to 16KiB from the end of the file. If the metadata section ends up being < 16KiB long, then one additional round trip has been saved. When the metadata section is longer, the additional read occurs to load the remaining portion of the metadata section.
pettyjamesm
force-pushed
the
parquet-footer-reads
branch
from
4aca1e1 to
71a3a05
Compare
Contributor
Author
|
@zhenxiao Addressed your prior feedback, ready for re-review. |
zhenxiao
approved these changes
Nov 12, 2020
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Attempts to reduce the number of reads required for parquet footers by pre-reading up to 16KiB from the end of the file. If the metadata section ends up being < 16KiB long, then one additional round trip has been saved. When the metadata section is longer, the additional read occurs to load the remaining portion of the metadata section.